tools/binary_size/explain_binary_size_delta.py - Issue 797363002: binary_size: Remove legacy path, keep / as / for unittests on windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/binary_size/explain_binary_size_delta.py

Issue 797363002: binary_size: Remove legacy path, keep / as / for unittests on windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/binary_size/explain_binary_size_delta.py

diff --git a/tools/binary_size/explain_binary_size_delta.py b/tools/binary_size/explain_binary_size_delta.py

index cb99fe6cc93981b3bec3ecff66e8ea0cb1a9fa07..d6eba2601224ae0bc0cc71d4986ffe1bf599cf8e 100755

--- a/tools/binary_size/explain_binary_size_delta.py

+++ b/tools/binary_size/explain_binary_size_delta.py

@@ -66,6 +66,8 @@ def Compare(symbols1, symbols2):

symbol_type = '@' # hack to categorize these separately

if file_path:

file_path = os.path.normpath(file_path)

+ if sys.platform.startswith('win'):

+ file_path = file_path.replace('\\', '/')

else:

file_path = '(No Path)'

key = (file_path, symbol_type)

« no previous file with comments | « no previous file | tools/binary_size/legacy_template/.gitignore » ('j') | no next file with comments »