Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 797283005: replace COMPILE_ASSERT with static_assert in bindings/ (Closed)

Created:
6 years ago by Mostyn Bramley-Moore
Modified:
6 years ago
Reviewers:
haraken, dcarney
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in bindings/ BUG=442514 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187359

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptValueSerializer.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptWrappable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/SerializedScriptValueFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8ScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WrapperTypeInfo.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/constants.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +18 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@dcarney: PTAL.
6 years ago (2014-12-16 23:27:06 UTC) #2
dcarney
lgtm
6 years ago (2014-12-17 08:27:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797283005/1
6 years ago (2014-12-17 08:30:07 UTC) #5
haraken
LGTM
6 years ago (2014-12-17 09:18:32 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-17 10:49:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187359

Powered by Google App Engine
This is Rietveld 408576698