Source/bindings/templates/constants.cpp - Issue 797283005: replace COMPILE_ASSERT with static_assert in bindings/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/constants.cpp

Issue 797283005: replace COMPILE_ASSERT with static_assert in bindings/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp ('k') | Source/bindings/tests/results/core/V8TestInterface2.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/constants.cpp

diff --git a/Source/bindings/templates/constants.cpp b/Source/bindings/templates/constants.cpp

index 44fb1e730d61fc97126c2c0fd6d548c5a9ad5be6..aecc12c486747f5be492ba918890b8ee2d199bc6 100644

--- a/Source/bindings/templates/constants.cpp

+++ b/Source/bindings/templates/constants.cpp

@@ -50,7 +50,7 @@ V8DOMConfiguration::installConstant(isolate, functionTemplate, prototypeTemplate

{% for constant in constants %}

{% if constant.idl_type not in ('Double', 'Float', 'String') %}

{% set constant_cpp_class = constant.cpp_class or cpp_class %}

-COMPILE_ASSERT({{constant.value}} == {{constant_cpp_class}}::{{constant.reflected_name}}, TheValueOf{{cpp_class}}_{{constant.reflected_name}}DoesntMatchWithImplementation);

+static_assert({{constant.value}} == {{constant_cpp_class}}::{{constant.reflected_name}}, "the value of {{cpp_class}}_{{constant.reflected_name}} does not match with implementation");

{% endif %}

{% endfor %}

{% endif %}