ots::EnableWOFF is no longer part of new OTS repo

ots::EnableWOFF is no longer part of new OTS repo.

We are updating OTS in https://codereview.chromium.org/775893002/ , 
ots::EnableWOFF method is not present in new OTS

BUG=339857

[h.joshi, 2014-12-04 07:56:19]

h.joshi@samsung.com changed reviewers:
+ behdad@chromium.org, eae@chromium.org, jshin@chromium.org

[h.joshi, 2014-12-04 07:57:49]

Pls review

[eae, 2014-12-04 19:34:17]

This depends on 658573004 which hasn't landed yet but the change itself LGTM,
please do not commit until 658573004 has landed though.

[jungshik at Google, 2014-12-04 21:12:51]

Is there any Blink test that will break with this CL (that tests WOFF2 support)?


In that case, we have to disable them in this CL. Then, we can land this CL
first, wait for it to be rolled in, land the OTS upstream-switch CL and finally
re-enable the disabled tests in another CL.

[jungshik at Google, 2014-12-04 21:16:08]

On 2014/12/04 21:12:51, Jungshik Shin wrote:
> Is there any Blink test that will break with this CL (that tests WOFF2
support)?
> 
> 
> In that case, we have to disable them in this CL. Then, we can land this CL
> first, wait for it to be rolled in, land the OTS upstream-switch CL and
finally
> re-enable the disabled tests in another CL.

Oh. Perhaps, we can do what Emil seems to have suggested, instead, to streamline
the process. 

1. Land the OTS upstream-switch CL by hand (hmm, it's a bit risky)
2. Land this CL immediately after that by hand.

[h.joshi, 2014-12-05 02:46:16]

How about:
1. Adding dummy "ots::EnableWOFF" in OTS patch, so that it
does not break anyone's build
2. Submit this CL
3. Re-edit OTS again with dummy "ots::EnableWOFF" removed.

Pls suggest, I feel with above nothing should break.

[blink-reviews, 2014-12-05 02:48:49]

I guess that works too.

Have you made progress with posting the color patch to github?

On Thu, Dec 4, 2014 at 6:46 PM, <h.joshi@samsung.com> wrote:

> How about:
> 1. Adding dummy "ots::EnableWOFF" in OTS patch, so that it
> does not break anyone's build
> 2. Submit this CL
> 3. Re-edit OTS again with dummy "ots::EnableWOFF" removed.
>
> Pls suggest, I feel with above nothing should break.
>
> https://codereview.chromium.org/774253008/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[h.joshi, 2014-12-05 04:07:46]

> Have you made progress with posting the color patch to github?
I have made changes, need to compile and test if every thing works fine.

[blink-reviews, 2014-12-05 04:11:39]

Please submit for review as is, so I can take a look tonight.  Thanks.

On Thu, Dec 4, 2014 at 8:07 PM, <h.joshi@samsung.com> wrote:

> Have you made progress with posting the color patch to github?
>>
> I have made changes, need to compile and test if every thing works fine.
>
> https://codereview.chromium.org/774253008/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[h.joshi, 2014-12-05 04:19:32]

@Behdad: Okey, currently getting following error when trying to submit.

Command "git config rietveld.server" failed.
Could not find settings file. You must configure your review setup by running
"git cl config".

[h.joshi, 2014-12-05 04:50:18]

@Behdad: I have uploaded patch in "https://codereview.appspot.com/185020043/"
Pls review and share your comments.

[h.joshi, 2014-12-12 06:30:40]

Patch https://codereview.chromium.org/775893002/ is committed, trying this
patch now.

[h.joshi, 2014-12-12 06:30:45]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-12-12 06:30:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/774253008/1

[commit-bot: I haz the power, 2014-12-12 06:41:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-12 06:41:14]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/97889)

[jungshik at Google, 2014-12-12 08:33:46]

The CQ bit was checked by jshin@chromium.org

[commit-bot: I haz the power, 2014-12-12 08:34:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/774253008/1

[jungshik at Google, 2014-12-12 09:05:20]

The CQ bit was unchecked by jshin@chromium.org

[jungshik at Google, 2014-12-12 09:06:23]

On 2014/12/12 08:34:47, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/774253008/1

OTS update patch was reverted. 'gn' build is failing because somehow it couldn't
find third_party/ots after DEPS change (ots is not in DEPS any more).