Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 797093005: Enable ScreenOrientation on ChromeOS (Closed)

Created:
6 years ago by jonross
Modified:
5 years, 11 months ago
Reviewers:
flackr
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ScreenOrientation on ChromeOS Remove the flag blocking ScreenOrientation to enable it by default. TBR=oshima@chromium.org BUG=396760 Committed: https://crrev.com/90cab9cb698467c3a8f0e4bc1020003f7e98d74f Cr-Commit-Position: refs/heads/master@{#309086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ash/content/display/screen_orientation_delegate_chromeos.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jonross
Hey Rob, Could you review this change to remove the flag on screen orientation?
6 years ago (2014-12-18 15:21:23 UTC) #2
flackr
lgtm
6 years ago (2014-12-18 20:58:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/797093005/1
6 years ago (2014-12-18 21:00:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 22:18:34 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/90cab9cb698467c3a8f0e4bc1020003f7e98d74f Cr-Commit-Position: refs/heads/master@{#309086}
6 years ago (2014-12-18 22:19:22 UTC) #7
jonross
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/835883006/ by jonross@chromium.org. ...
5 years, 11 months ago (2015-01-06 21:52:16 UTC) #8
jonross
5 years, 11 months ago (2015-01-06 23:03:04 UTC) #9
Message was sent while issue was closed.
On 2015/01/06 21:52:16, jonross wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/835883006/ by mailto:jonross@chromium.org.
> 
> The reason for reverting is: This feature was not approved for release in
M-41.
> Re-disabling it by default..

A direct revert is not possible due to CommandLine no longer compiling. Manual
revert is up with the correct base::CommandLine

https://codereview.chromium.org/831153003

Powered by Google App Engine
This is Rietveld 408576698