Issue 831153003: Revert of Enable ScreenOrientation on ChromeOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 831153003: Revert of Enable ScreenOrientation on ChromeOS (Closed)

Created:
5 years, 11 months ago by jonross

Modified:
5 years, 11 months ago

Reviewers:
oshima

CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Enable ScreenOrientation on ChromeOS Revert of Enable ScreenOrientation on ChromeOS (patchset #1 id:1 of https://codereview.chromium.org/797093005/) Reason for revert: This feature was not approved for release in M-41. Re-disabling it by default. Original issue's description: > Enable ScreenOrientation on ChromeOS > > Remove the flag blocking ScreenOrientation to enable it by default. > > TBR=oshima@chromium.org > BUG=396760 > > Committed: https://crrev.com/90cab9cb698467c3a8f0e4bc1020003f7e98d74f > Cr-Commit-Position: refs/heads/master@{#309086} TBR=oshima@chromium.org BUG=396760 Committed: https://crrev.com/cd2efb7bc92380febe1d71dd8be6d3cba81bb1dd Cr-Commit-Position: refs/heads/master@{#310206}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	ash/content/display/screen_orientation_delegate_chromeos.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/831153003/1

5 years, 11 months ago (2015-01-07 00:30:32 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-07 01:19:33 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/cd2efb7bc92380febe1d71dd8be6d3cba81bb1dd
Cr-Commit-Position: refs/heads/master@{#310206}