Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 796913002: Use C++11 range-based loop for core/clipboard, core/dom and core/testing (Closed)

Created:
6 years ago by zhaoze.zhou
Modified:
5 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-paint_chromium.org, dcheng, dglazkov+blink, dstockwell, eae+blinkwatch, Eric Willigers, Mike Lawther (Google), rjwright, rwlbuis, shans, sof, slimming-paint-reviews_chromium.org, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use C++11 range-based loop for core/clipboard, core/dom and core/testing Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188359

Patch Set 1 #

Patch Set 2 : remove unused variable #

Total comments: 2

Patch Set 3 : rename variable #

Total comments: 6

Patch Set 4 : make auto clear #

Total comments: 15

Patch Set 5 : fix #

Total comments: 4

Patch Set 6 : change to ref #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -68 lines) Patch
M Source/core/clipboard/DataObject.cpp View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 1 2 3 4 2 chunks +2 lines, -8 lines 0 comments Download
M Source/core/dom/ElementData.cpp View 1 2 3 4 5 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 2 3 4 5 6 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/MutationObserverInterestGroup.cpp View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/MutationObserverRegistration.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeListsNodeData.cpp View 1 2 3 1 chunk +4 lines, -6 lines 0 comments Download
M Source/core/dom/ScriptedAnimationController.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/dom/WeakNodeMap.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 2 3 4 5 6 6 chunks +12 lines, -16 lines 0 comments Download

Messages

Total messages: 28 (10 generated)
zhaoze.zhou
6 years ago (2014-12-16 15:20:02 UTC) #4
Julien - ping for review
This patch shouldn't land without good variable names. The type of the variables are not ...
6 years ago (2014-12-16 16:37:22 UTC) #6
zhaoze.zhou
https://codereview.chromium.org/796913002/diff/60001/Source/core/clipboard/DataObject.cpp File Source/core/clipboard/DataObject.cpp (right): https://codereview.chromium.org/796913002/diff/60001/Source/core/clipboard/DataObject.cpp#newcode52 Source/core/clipboard/DataObject.cpp:52: for (const auto& it : types) { On 2014/12/16 ...
6 years ago (2014-12-16 19:47:35 UTC) #7
dcheng
https://codereview.chromium.org/796913002/diff/80001/Source/core/dom/DocumentMarkerController.cpp File Source/core/dom/DocumentMarkerController.cpp (right): https://codereview.chromium.org/796913002/diff/80001/Source/core/dom/DocumentMarkerController.cpp#newcode447 Source/core/dom/DocumentMarkerController.cpp:447: for (DocumentMarker* marker : markersFor(node)) { Nit: space. https://codereview.chromium.org/796913002/diff/80001/Source/core/dom/ElementData.cpp ...
6 years ago (2014-12-16 19:52:51 UTC) #9
zhaoze.zhou
https://codereview.chromium.org/796913002/diff/80001/Source/core/dom/DocumentMarkerController.cpp File Source/core/dom/DocumentMarkerController.cpp (right): https://codereview.chromium.org/796913002/diff/80001/Source/core/dom/DocumentMarkerController.cpp#newcode447 Source/core/dom/DocumentMarkerController.cpp:447: for (DocumentMarker* marker : markersFor(node)) { On 2014/12/16 19:52:51, ...
6 years ago (2014-12-16 23:27:57 UTC) #12
Julien - ping for review
lgtm with the comments addressed. Daniel should double-check too. https://codereview.chromium.org/796913002/diff/140001/Source/core/clipboard/DataObject.cpp File Source/core/clipboard/DataObject.cpp (right): https://codereview.chromium.org/796913002/diff/140001/Source/core/clipboard/DataObject.cpp#newcode52 Source/core/clipboard/DataObject.cpp:52: ...
5 years, 11 months ago (2015-01-02 09:42:03 UTC) #13
zhaoze.zhou
https://codereview.chromium.org/796913002/diff/140001/Source/core/clipboard/DataObject.cpp File Source/core/clipboard/DataObject.cpp (right): https://codereview.chromium.org/796913002/diff/140001/Source/core/clipboard/DataObject.cpp#newcode52 Source/core/clipboard/DataObject.cpp:52: for (const auto& type : types) { On 2015/01/02 ...
5 years, 11 months ago (2015-01-05 15:17:57 UTC) #14
dcheng
https://codereview.chromium.org/796913002/diff/140001/Source/core/dom/DocumentMarkerController.cpp File Source/core/dom/DocumentMarkerController.cpp (right): https://codereview.chromium.org/796913002/diff/140001/Source/core/dom/DocumentMarkerController.cpp#newcode447 Source/core/dom/DocumentMarkerController.cpp:447: for (DocumentMarker* marker : markersFor(node)) { On 2015/01/05 15:17:57, ...
5 years, 11 months ago (2015-01-05 22:01:10 UTC) #15
zhaoze.zhou
https://codereview.chromium.org/796913002/diff/160001/Source/core/clipboard/DataObject.cpp File Source/core/clipboard/DataObject.cpp (right): https://codereview.chromium.org/796913002/diff/160001/Source/core/clipboard/DataObject.cpp#newcode52 Source/core/clipboard/DataObject.cpp:52: for (const String type : types) { On 2015/01/05 ...
5 years, 11 months ago (2015-01-09 02:30:05 UTC) #16
Julien - ping for review
Sorry I missed the description but we should be a bit more specific about what ...
5 years, 11 months ago (2015-01-09 09:28:52 UTC) #17
zhaoze.zhou
On 2015/01/09 09:28:52, Julien Chaffraix - CET wrote: > Sorry I missed the description but ...
5 years, 11 months ago (2015-01-12 05:12:48 UTC) #18
Julien - ping for review
Awesome, thanks for fixing the description.
5 years, 11 months ago (2015-01-12 10:02:28 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796913002/180001
5 years, 11 months ago (2015-01-12 10:03:21 UTC) #21
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/StyleEngine.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 11 months ago (2015-01-12 10:03:38 UTC) #23
zhaoze.zhou
On 2015/01/12 10:03:38, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
5 years, 11 months ago (2015-01-14 04:42:01 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796913002/200001
5 years, 11 months ago (2015-01-14 04:42:36 UTC) #26
commit-bot: I haz the power
Committed patchset #7 (id:200001) as https://src.chromium.org/viewvc/blink?view=rev&revision=188359
5 years, 11 months ago (2015-01-14 05:33:47 UTC) #27
inferno
5 years, 10 months ago (2015-01-30 04:52:26 UTC) #28
Message was sent while issue was closed.
On 2015/01/14 05:33:47, I haz the power (commit-bot) wrote:
> Committed patchset #7 (id:200001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=188359

This regressed and caused a bad security bug
[https://code.google.com/p/chromium/issues/detail?id=453279]. What is your email
that i can use in issue tracker to cc. Please contact me at inferno@chromium.org

Powered by Google App Engine
This is Rietveld 408576698