Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: Source/core/dom/MutationObserver.cpp

Issue 796913002: Use C++11 range-based loop for core/clipboard, core/dom and core/testing (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 records.swap(m_records); 149 records.swap(m_records);
150 InspectorInstrumentation::didClearAllMutationRecords(m_callback->executionCo ntext(), this); 150 InspectorInstrumentation::didClearAllMutationRecords(m_callback->executionCo ntext(), this);
151 return records; 151 return records;
152 } 152 }
153 153
154 void MutationObserver::disconnect() 154 void MutationObserver::disconnect()
155 { 155 {
156 m_records.clear(); 156 m_records.clear();
157 InspectorInstrumentation::didClearAllMutationRecords(m_callback->executionCo ntext(), this); 157 InspectorInstrumentation::didClearAllMutationRecords(m_callback->executionCo ntext(), this);
158 MutationObserverRegistrationSet registrations(m_registrations); 158 MutationObserverRegistrationSet registrations(m_registrations);
159 for (MutationObserverRegistrationSet::iterator iter = registrations.begin(); iter != registrations.end(); ++iter) 159 for (auto& registration : registrations)
160 (*iter)->unregister(); 160 registration->unregister();
161 ASSERT(m_registrations.isEmpty()); 161 ASSERT(m_registrations.isEmpty());
162 } 162 }
163 163
164 void MutationObserver::observationStarted(MutationObserverRegistration* registra tion) 164 void MutationObserver::observationStarted(MutationObserverRegistration* registra tion)
165 { 165 {
166 ASSERT(!m_registrations.contains(registration)); 166 ASSERT(!m_registrations.contains(registration));
167 m_registrations.add(registration); 167 m_registrations.add(registration);
168 } 168 }
169 169
170 void MutationObserver::observationEnded(MutationObserverRegistration* registrati on) 170 void MutationObserver::observationEnded(MutationObserverRegistration* registrati on)
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 203
204 void MutationObserver::setHasTransientRegistration() 204 void MutationObserver::setHasTransientRegistration()
205 { 205 {
206 ASSERT(isMainThread()); 206 ASSERT(isMainThread());
207 activateObserver(this); 207 activateObserver(this);
208 } 208 }
209 209
210 WillBeHeapHashSet<RawPtrWillBeMember<Node> > MutationObserver::getObservedNodes( ) const 210 WillBeHeapHashSet<RawPtrWillBeMember<Node> > MutationObserver::getObservedNodes( ) const
211 { 211 {
212 WillBeHeapHashSet<RawPtrWillBeMember<Node> > observedNodes; 212 WillBeHeapHashSet<RawPtrWillBeMember<Node> > observedNodes;
213 for (MutationObserverRegistrationSet::const_iterator iter = m_registrations. begin(); iter != m_registrations.end(); ++iter) 213 for (const auto& registration : m_registrations)
214 (*iter)->addRegistrationNodesToSet(observedNodes); 214 registration->addRegistrationNodesToSet(observedNodes);
215 return observedNodes; 215 return observedNodes;
216 } 216 }
217 217
218 bool MutationObserver::shouldBeSuspended() const 218 bool MutationObserver::shouldBeSuspended() const
219 { 219 {
220 return m_callback->executionContext() && m_callback->executionContext()->act iveDOMObjectsAreSuspended(); 220 return m_callback->executionContext() && m_callback->executionContext()->act iveDOMObjectsAreSuspended();
221 } 221 }
222 222
223 void MutationObserver::deliver() 223 void MutationObserver::deliver()
224 { 224 {
225 ASSERT(!shouldBeSuspended()); 225 ASSERT(!shouldBeSuspended());
226 226
227 // Calling clearTransientRegistrations() can modify m_registrations, so it's necessary 227 // Calling clearTransientRegistrations() can modify m_registrations, so it's necessary
228 // to make a copy of the transient registrations before operating on them. 228 // to make a copy of the transient registrations before operating on them.
229 WillBeHeapVector<RawPtrWillBeMember<MutationObserverRegistration>, 1> transi entRegistrations; 229 WillBeHeapVector<RawPtrWillBeMember<MutationObserverRegistration>, 1> transi entRegistrations;
230 for (MutationObserverRegistrationSet::iterator iter = m_registrations.begin( ); iter != m_registrations.end(); ++iter) { 230 for (auto& registration : m_registrations) {
231 if ((*iter)->hasTransientRegistrations()) 231 if (registration->hasTransientRegistrations())
232 transientRegistrations.append(*iter); 232 transientRegistrations.append(registration);
233 } 233 }
234 for (size_t i = 0; i < transientRegistrations.size(); ++i) 234 for (size_t i = 0; i < transientRegistrations.size(); ++i)
235 transientRegistrations[i]->clearTransientRegistrations(); 235 transientRegistrations[i]->clearTransientRegistrations();
236 236
237 if (m_records.isEmpty()) 237 if (m_records.isEmpty())
238 return; 238 return;
239 239
240 MutationRecordVector records; 240 MutationRecordVector records;
241 records.swap(m_records); 241 records.swap(m_records);
242 242
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 { 280 {
281 #if ENABLE(OILPAN) 281 #if ENABLE(OILPAN)
282 visitor->trace(m_callback); 282 visitor->trace(m_callback);
283 visitor->trace(m_records); 283 visitor->trace(m_records);
284 visitor->trace(m_registrations); 284 visitor->trace(m_registrations);
285 visitor->trace(m_callback); 285 visitor->trace(m_callback);
286 #endif 286 #endif
287 } 287 }
288 288
289 } // namespace blink 289 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/IdTargetObserverRegistry.cpp ('k') | Source/core/dom/MutationObserverInterestGroup.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698