build/module_args/v8.gni - Issue 796903002: [GN] Set v8_use_external_snapshot_data for the same configurations as GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/module_args/v8.gni

Issue 796903002: [GN] Set v8_use_external_snapshot_data for the same configurations as GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix location of natives_blob.bin and snapshot_blob.bin after their output was moved in V8 Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/module_args/v8.gni

diff --git a/build/module_args/v8.gni b/build/module_args/v8.gni

index 5825530ae4031db6a14fb1308054de10a1b68b96..e4bbf46b3e7ab92903ac536ca5859e8ce32ae479 100644

--- a/build/module_args/v8.gni

+++ b/build/module_args/v8.gni

@@ -6,7 +6,5 @@ if (is_android) {

import("//build/config/android/config.gni")

}

-# TODO(baixo) enable this once this lands:

-# https://codereview.chromium.org/749213004

-# v8_use_external_startup_data = is_android && !is_android_webview_build

-v8_use_external_startup_data = false

+v8_use_external_startup_data =

+ !((is_android && is_android_webview_build) || is_chromeos || is_win)

« no previous file with comments | « no previous file | chrome/android/BUILD.gn » ('j') | no next file with comments »