chrome/android/BUILD.gn - Issue 796903002: [GN] Set v8_use_external_snapshot_data for the same configurations as GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/BUILD.gn

Issue 796903002: [GN] Set v8_use_external_snapshot_data for the same configurations as GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix location of natives_blob.bin and snapshot_blob.bin after their output was moved in V8 Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/BUILD.gn

diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn

index c63bf0d35f627857728a10a02a37e0c0be066222..0e2865f91280378072db6ca6eb02897fa1bfba98 100644

--- a/chrome/android/BUILD.gn

+++ b/chrome/android/BUILD.gn

@@ -331,8 +331,8 @@ copy_ex("chrome_shell_assets") {

}

if (v8_use_external_startup_data) {

sources += [

- "$root_gen_dir/natives_blob.bin",

- "$root_gen_dir/snapshot_blob.bin",

+ "$root_build_dir/natives_blob.bin",

+ "$root_build_dir/snapshot_blob.bin",

]

}

« no previous file with comments | « build/module_args/v8.gni ('k') | content/shell/android/BUILD.gn » ('j') | no next file with comments »