Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 796903002: [GN] Set v8_use_external_snapshot_data for the same configurations as GN. (Closed)

Created:
6 years ago by rmcilroy
Modified:
6 years ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[GN] Set v8_use_external_snapshot_data for the same configurations as GN. BUG=421063 Committed: https://crrev.com/def2eb00493259ff297e8792fee35dc7dc2204b5 Cr-Commit-Position: refs/heads/master@{#308779} Committed: https://crrev.com/5837d33dbfd3d22dbf08182c8b893173b82ccc0d Cr-Commit-Position: refs/heads/master@{#308793}

Patch Set 1 : #

Patch Set 2 : Fix net_unittests #

Patch Set 3 : Fix location of natives_blob.bin and snapshot_blob.bin after their output was moved in V8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M build/module_args/v8.gni View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M net/BUILD.gn View 1 2 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
rmcilroy
brettw: could you please take a look, thanks.
6 years ago (2014-12-11 18:35:29 UTC) #3
brettw
lgtm
6 years ago (2014-12-12 21:59:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796903002/40001
6 years ago (2014-12-14 17:02:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/42865)
6 years ago (2014-12-14 18:02:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796903002/40001
6 years ago (2014-12-17 11:10:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years ago (2014-12-17 11:44:48 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/def2eb00493259ff297e8792fee35dc7dc2204b5 Cr-Commit-Position: refs/heads/master@{#308779}
6 years ago (2014-12-17 11:45:34 UTC) #12
rmcilroy
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/808833003/ by rmcilroy@chromium.org. ...
6 years ago (2014-12-17 12:09:47 UTC) #13
Marc Treib
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/805333003/ by treib@chromium.org. ...
6 years ago (2014-12-17 12:13:08 UTC) #14
rmcilroy
On 2014/12/17 12:13:08, Marc Treib wrote: > A revert of this CL (patchset #2 id:40001) ...
6 years ago (2014-12-17 13:48:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796903002/60001
6 years ago (2014-12-17 13:49:07 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001)
6 years ago (2014-12-17 14:31:06 UTC) #18
commit-bot: I haz the power
6 years ago (2014-12-17 14:32:03 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5837d33dbfd3d22dbf08182c8b893173b82ccc0d
Cr-Commit-Position: refs/heads/master@{#308793}

Powered by Google App Engine
This is Rietveld 408576698