Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 796693005: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/input_method. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
Zachary Kuznia
CC:
aboxhall+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, stevenjb+watch_chromium.org, yukishiino+watch_chromium.org, yusukes+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/input_method. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=zork@chromium.org Committed: https://crrev.com/88b646e4232226053540eac1600967780a5a357b Cr-Commit-Position: refs/heads/master@{#311788}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -320 lines) Patch
M chrome/browser/chromeos/input_method/accessibility.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/browser_state_monitor.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.h View 2 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_delegate_impl.h View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.h View 1 chunk +44 lines, -43 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_unittest.cc View 2 chunks +19 lines, -24 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 4 chunks +51 lines, -63 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_syncer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mock_candidate_window_controller.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_engine.h View 1 chunk +44 lines, -43 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 2 chunks +45 lines, -57 lines 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_browsertest.cc View 5 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/textinput_test_helper.h View 3 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:07:24 UTC) #1
Zachary Kuznia
lgtm
5 years, 11 months ago (2015-01-15 23:07:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796693005/1
5 years, 11 months ago (2015-01-15 23:11:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 00:45:16 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:46:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88b646e4232226053540eac1600967780a5a357b
Cr-Commit-Position: refs/heads/master@{#311788}

Powered by Google App Engine
This is Rietveld 408576698