Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

Issue 796693005: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/input_method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
index a51cf87dc7f50bafa2a3e42d76d342825b4916ec..4cde59c0181dc26a7ed6cb4743900f350e5e8c5c 100644
--- a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc
@@ -68,14 +68,14 @@ class TestObserver : public InputMethodManager::Observer,
input_method_menu_item_changed_count_(0),
last_show_message_(false) {
}
- virtual ~TestObserver() {}
+ ~TestObserver() override {}
- virtual void InputMethodChanged(InputMethodManager* manager,
- bool show_message) override {
+ void InputMethodChanged(InputMethodManager* manager,
+ bool show_message) override {
++input_method_changed_count_;
last_show_message_ = show_message;
}
- virtual void InputMethodMenuItemChanged(
+ void InputMethodMenuItemChanged(
ui::ime::InputMethodMenuManager* manager) override {
++input_method_menu_item_changed_count_;
}
@@ -96,12 +96,12 @@ class TestCandidateWindowObserver
candidate_window_closed_count_(0) {
}
- virtual ~TestCandidateWindowObserver() {}
+ ~TestCandidateWindowObserver() override {}
- virtual void CandidateWindowOpened(InputMethodManager* manager) override {
+ void CandidateWindowOpened(InputMethodManager* manager) override {
++candidate_window_opened_count_;
}
- virtual void CandidateWindowClosed(InputMethodManager* manager) override {
+ void CandidateWindowClosed(InputMethodManager* manager) override {
++candidate_window_closed_count_;
}
@@ -120,9 +120,9 @@ class InputMethodManagerImplTest : public BrowserWithTestWindowTest {
candidate_window_controller_(NULL),
keyboard_(NULL) {
}
- virtual ~InputMethodManagerImplTest() {}
+ ~InputMethodManagerImplTest() override {}
- virtual void SetUp() override {
+ void SetUp() override {
profile_manager_.reset(new TestingProfileManager(GetBrowserProcess()));
ASSERT_TRUE(profile_manager_->SetUp());
@@ -148,7 +148,7 @@ class InputMethodManagerImplTest : public BrowserWithTestWindowTest {
BrowserWithTestWindowTest::SetUp();
}
- virtual void TearDown() override {
+ void TearDown() override {
BrowserWithTestWindowTest::TearDown();
ui::ShutdownInputMethodForTesting();

Powered by Google App Engine
This is Rietveld 408576698