Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 796543003: Stricter parsing for size attribute on HTMLInputElement (Closed)

Created:
6 years ago by rwlbuis
Modified:
6 years ago
Reviewers:
tkent
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Stricter parsing for size attribute on HTMLInputElement According to the latest spec "the size attribute, if specified, must have a value that is a valid non-negative integer greater than zero. If the attribute is present, then its value must be parsed using the rules for parsing non-negative integers." With this patch parsing is more strict and above rules are honored. This was showing as failures here, fixed with this patch: http://w3c-test.org/html/dom/reflection-forms.html Behavior matches Firefox. Spec reference: https://html.spec.whatwg.org/multipage/forms.html#attr-input-size Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187006

Patch Set 1 #

Patch Set 2 : Add some subtests #

Patch Set 3 : Fix compile problem #

Patch Set 4 : Add some subtests that actually make a difference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M LayoutTests/fast/dom/HTMLInputElement/script-tests/size-attribute.js View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/HTMLInputElement/size-attribute-expected.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
rwlbuis
6 years ago (2014-12-11 19:49:10 UTC) #2
rwlbuis
On 2014/12/11 19:49:10, rwlbuis wrote: Oops, PTAL :)
6 years ago (2014-12-11 19:49:20 UTC) #3
tkent
lgtm
6 years ago (2014-12-12 00:24:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796543003/60001
6 years ago (2014-12-12 00:24:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41044)
6 years ago (2014-12-12 01:03:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796543003/60001
6 years ago (2014-12-12 01:10:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/41066)
6 years ago (2014-12-12 01:47:04 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796543003/60001
6 years ago (2014-12-12 02:41:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/37152)
6 years ago (2014-12-12 05:04:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796543003/60001
6 years ago (2014-12-12 07:57:32 UTC) #18
commit-bot: I haz the power
6 years ago (2014-12-12 09:16:21 UTC) #19
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187006

Powered by Google App Engine
This is Rietveld 408576698