Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 796543003: Stricter parsing for size attribute on HTMLInputElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add some subtests that actually make a difference Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/dom/HTMLInputElement/size-attribute-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 708 matching lines...) Expand 10 before | Expand all | Expand 10 after
719 if (!m_parsingInProgress && m_reflectsCheckedAttribute) { 719 if (!m_parsingInProgress && m_reflectsCheckedAttribute) {
720 setChecked(!value.isNull()); 720 setChecked(!value.isNull());
721 m_reflectsCheckedAttribute = true; 721 m_reflectsCheckedAttribute = true;
722 } 722 }
723 } else if (name == maxlengthAttr) { 723 } else if (name == maxlengthAttr) {
724 parseMaxLengthAttribute(value); 724 parseMaxLengthAttribute(value);
725 } else if (name == minlengthAttr) { 725 } else if (name == minlengthAttr) {
726 parseMinLengthAttribute(value); 726 parseMinLengthAttribute(value);
727 } else if (name == sizeAttr) { 727 } else if (name == sizeAttr) {
728 int oldSize = m_size; 728 int oldSize = m_size;
729 int valueAsInteger = value.toInt(); 729 m_size = defaultSize;
730 m_size = valueAsInteger > 0 ? valueAsInteger : defaultSize; 730 int valueAsInteger;
731 if (!value.isEmpty() && parseHTMLInteger(value, valueAsInteger) && value AsInteger > 0)
732 m_size = valueAsInteger;
731 if (m_size != oldSize && renderer()) 733 if (m_size != oldSize && renderer())
732 renderer()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidatio n(); 734 renderer()->setNeedsLayoutAndPrefWidthsRecalcAndFullPaintInvalidatio n();
733 } else if (name == altAttr) 735 } else if (name == altAttr)
734 m_inputTypeView->altAttributeChanged(); 736 m_inputTypeView->altAttributeChanged();
735 else if (name == srcAttr) 737 else if (name == srcAttr)
736 m_inputTypeView->srcAttributeChanged(); 738 m_inputTypeView->srcAttributeChanged();
737 else if (name == usemapAttr || name == accesskeyAttr) { 739 else if (name == usemapAttr || name == accesskeyAttr) {
738 // FIXME: ignore for the moment 740 // FIXME: ignore for the moment
739 } else if (name == onsearchAttr) { 741 } else if (name == onsearchAttr) {
740 // Search field and slider attributes all just cause updateFromElement t o be called through style recalcing. 742 // Search field and slider attributes all just cause updateFromElement t o be called through style recalcing.
(...skipping 1151 matching lines...) Expand 10 before | Expand all | Expand 10 after
1892 { 1894 {
1893 listAttributeTargetChanged(); 1895 listAttributeTargetChanged();
1894 } 1896 }
1895 1897
1896 AXObject* HTMLInputElement::popupRootAXObject() 1898 AXObject* HTMLInputElement::popupRootAXObject()
1897 { 1899 {
1898 return m_inputTypeView->popupRootAXObject(); 1900 return m_inputTypeView->popupRootAXObject();
1899 } 1901 }
1900 1902
1901 } // namespace 1903 } // namespace
OLDNEW
« no previous file with comments | « LayoutTests/fast/dom/HTMLInputElement/size-attribute-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698