Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 796503004: [Android] Work around pm path bug in L. (Closed)

Created:
6 years ago by jbudorick
Modified:
6 years ago
Reviewers:
klundberg, perezju
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Work around pm path bug in L. Dependent on https://codereview.chromium.org/787393003/ BUG= Committed: https://crrev.com/b65dfa3e161c4ccfd3a1e39447fc1f38228895f4 Cr-Commit-Position: refs/heads/master@{#308197}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added TODO for future SDK versions. #

Patch Set 3 : rebase + fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M build/android/pylib/device/device_utils.py View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 2 1 chunk +11 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jbudorick
6 years ago (2014-12-12 00:36:01 UTC) #2
klundberg
https://codereview.chromium.org/796503004/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/796503004/diff/1/build/android/pylib/device/device_utils.py#newcode254 build/android/pylib/device/device_utils.py:254: should_check_return = (self.build_version_sdk < So this is starting in ...
6 years ago (2014-12-12 00:40:06 UTC) #3
klundberg
lgtm
6 years ago (2014-12-12 01:24:14 UTC) #4
perezju
lgtm, but I guess it depends on landing https://codereview.chromium.org/787393003/ first?
6 years ago (2014-12-12 10:14:08 UTC) #5
perezju
On 2014/12/12 10:14:08, perezju wrote: > lgtm, but I guess it depends on landing > ...
6 years ago (2014-12-12 10:15:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796503004/40001
6 years ago (2014-12-12 21:53:50 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-12 23:53:51 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-12 23:54:30 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b65dfa3e161c4ccfd3a1e39447fc1f38228895f4
Cr-Commit-Position: refs/heads/master@{#308197}

Powered by Google App Engine
This is Rietveld 408576698