[Android] Work around pm path bug in L.

build/android/pylib/device/device_utils.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provides a variety of device interactions based on adb.
 
 Eventually, this will be based on adb_wrapper.
 """
 # pylint: disable=W0613
 
@@ skipping 231 matching lines @@
   @decorators.WithTimeoutAndRetriesFromInstance()
   def GetApplicationPath(self, package, timeout=None, retries=None):
     """Get the path of the installed apk on the device for the given package.
 
     Args:
       package: Name of the package.
 
     Returns:
       Path to the apk on the device if it exists, None otherwise.
     """
+    # 'pm path' is liable to incorrectly exit with a nonzero number starting
+    # in Lollipop.
+    should_check_return = (self.build_version_sdk <

[klundberg, 2014/12/12 00:40:06]

So this is starting in Lollipop but might be fixed in M or even L MR1. As it is,
your fix assumes that this will be a problem in future versions of Android. I
suggest to at least have a TODO or something to test this with L MR1 and future
versions.
Furthermore, do you know of an Android bug for this? If no, I suggest filing
such a bug.

+                           constants.ANDROID_SDK_VERSION_CODES.LOLLIPOP)
     output = self.RunShellCommand(['pm', 'path', package], single_line=True,
-                                  check_return=True)
+                                  check_return=should_check_return)
     if not output:
       return None
     if not output.startswith('package:'):
       raise device_errors.CommandFailedError('pm path returned: %r' % output,
                                              str(self))
     return output[len('package:'):]
 
   @decorators.WithTimeoutAndRetriesFromInstance()
   def WaitUntilFullyBooted(self, wifi=False, timeout=None, retries=None):
     """Wait for the device to fully boot.
@@ skipping 926 matching lines @@
     Returns:
       A Parallelizer operating over |devices|.
     """
     if not devices:
       devices = adb_wrapper.AdbWrapper.GetDevices()
     devices = [d if isinstance(d, cls) else cls(d) for d in devices]
     if async:
       return parallelizer.Parallelizer(devices)
     else:
       return parallelizer.SyncParallelizer(devices)