Chromium Code Reviews| Index: chrome/renderer/autofill/autofill_renderer_browsertest.cc |
| diff --git a/chrome/renderer/autofill/autofill_renderer_browsertest.cc b/chrome/renderer/autofill/autofill_renderer_browsertest.cc |
| index cd1c8d3fbf583d8ac2af9e2b3257a61a2135f3c8..05d75c53472bbf362a01f6561cfd12a21aa38aac 100644 |
| --- a/chrome/renderer/autofill/autofill_renderer_browsertest.cc |
| +++ b/chrome/renderer/autofill/autofill_renderer_browsertest.cc |
| @@ -366,51 +366,6 @@ class RequestAutocompleteRendererTest : public AutofillRendererTest { |
| DISALLOW_COPY_AND_ASSIGN(RequestAutocompleteRendererTest); |
| }; |
| -TEST_F(RequestAutocompleteRendererTest, SiblingNavigateIgnored) { |
| - // Pretend that a sibling frame navigated. No cancel should be sent. |
| - NavigateFrame(sibling_frame()); |
| - EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching( |
| - AutofillHostMsg_CancelRequestAutocomplete::ID)); |
| -} |
| - |
| -TEST_F(RequestAutocompleteRendererTest, SubframeNavigateCancels) { |
|
Dan Beam
2014/12/19 01:59:34
where are the equivalent tests to ensure an <ifram
Evan Stade
2014/12/19 21:21:12
added. I don't know how it worked before, but I ha
|
| - // Pretend that the invoking frame navigated. A cancel should be sent. |
| - NavigateFrame(invoking_frame()); |
| - EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching( |
| - AutofillHostMsg_CancelRequestAutocomplete::ID)); |
| -} |
| - |
| -TEST_F(RequestAutocompleteRendererTest, MainFrameNavigateCancels) { |
| - // Pretend that the top-level frame navigated. A cancel should be sent. |
| - NavigateFrame(GetMainFrame()); |
| - EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching( |
| - AutofillHostMsg_CancelRequestAutocomplete::ID)); |
| -} |
| - |
| -TEST_F(RequestAutocompleteRendererTest, NoCancelOnSubframeNavigateAfterDone) { |
| - // Pretend that the dialog was cancelled. |
| - SimulateRequestAutocompleteResult( |
| - invoking_frame_, WebFormElement::AutocompleteResultErrorCancel, |
| - base::ASCIIToUTF16("Print me to the console")); |
| - |
| - // Additional navigations should not crash nor send cancels. |
| - NavigateFrame(invoking_frame()); |
| - EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching( |
| - AutofillHostMsg_CancelRequestAutocomplete::ID)); |
| -} |
| - |
| -TEST_F(RequestAutocompleteRendererTest, NoCancelOnMainFrameNavigateAfterDone) { |
| - // Pretend that the dialog was cancelled. |
| - SimulateRequestAutocompleteResult( |
| - invoking_frame_, WebFormElement::AutocompleteResultErrorCancel, |
| - base::ASCIIToUTF16("Print me to the console")); |
| - |
| - // Additional navigations should not crash nor send cancels. |
| - NavigateFrame(GetMainFrame()); |
| - EXPECT_FALSE(render_thread_->sink().GetFirstMessageMatching( |
| - AutofillHostMsg_CancelRequestAutocomplete::ID)); |
| -} |
| - |
| TEST_F(RequestAutocompleteRendererTest, InvokingTwiceOnlyShowsOnce) { |
| // Attempting to show the requestAutocomplete dialog again should be ignored. |
| invoking_frame_->autofillClient()->didRequestAutocomplete(invoking_form()); |