Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: components/autofill/content/browser/request_autocomplete_manager.cc

Issue 796493004: Remove FrameDetached and FrameWillClose listeners from AutofillAgent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix init order Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/browser/request_autocomplete_manager.cc
diff --git a/components/autofill/content/browser/request_autocomplete_manager.cc b/components/autofill/content/browser/request_autocomplete_manager.cc
index df2d095b42042a0a46632f2b0182b9f4392569eb..8d12633763696bd02537d89852c8e67e58854d0b 100644
--- a/components/autofill/content/browser/request_autocomplete_manager.cc
+++ b/components/autofill/content/browser/request_autocomplete_manager.cc
@@ -45,21 +45,14 @@ RequestAutocompleteManager::RequestAutocompleteManager(
RequestAutocompleteManager::~RequestAutocompleteManager() {}
-void RequestAutocompleteManager::OnRequestAutocomplete(
- const FormData& form,
- const GURL& frame_url) {
+void RequestAutocompleteManager::OnRequestAutocomplete(const FormData& form) {
if (!IsValidFormData(form))
return;
AutofillClient::ResultCallback callback =
base::Bind(&RequestAutocompleteManager::ReturnAutocompleteResult,
weak_ptr_factory_.GetWeakPtr());
- ShowRequestAutocompleteDialog(form, frame_url, callback);
-}
-
-void RequestAutocompleteManager::OnCancelRequestAutocomplete() {
- autofill_driver_->autofill_manager()->client()
- ->HideRequestAutocompleteDialog();
+ ShowRequestAutocompleteDialog(form, callback);
}
void RequestAutocompleteManager::ReturnAutocompleteResult(
@@ -88,10 +81,10 @@ void RequestAutocompleteManager::ReturnAutocompleteResult(
void RequestAutocompleteManager::ShowRequestAutocompleteDialog(
const FormData& form,
- const GURL& source_url,
const AutofillClient::ResultCallback& callback) {
AutofillClient* client = autofill_driver_->autofill_manager()->client();
- client->ShowRequestAutocompleteDialog(form, source_url, callback);
+ client->ShowRequestAutocompleteDialog(
+ form, autofill_driver_->render_frame_host(), callback);
}
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698