chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc - Issue 796253002: Fix use-after-free when browser is closed during a drop-drop on desktop Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

Issue 796253002: Fix use-after-free when browser is closed during a drop-drop on desktop Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc » ('j') | ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

index dbceb13bbeb6f9df748a7ca4a28296c98d56f5de..15a99067453864ccda11ce653149e1d08c3a33be 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

@@ -2057,10 +2057,7 @@ class BookmarkBarViewTest22 : public BookmarkBarViewEventTestBase {

}

};

-#if defined(OS_LINUX) && !defined(OS_CHROMEOS)

-// TODO(pkotwicz): Enable on Desktop Linux once crbug.com/438365 is fixed.

-#define MAYBE_CloseSourceBrowserDuringDrag DISABLED_CloseSourceBrowserDuringDrag

-#elif defined(OS_WIN)

+#if defined(OS_WIN)

// This test times out on Windows. TODO(pkotwicz): Find out why.

#define MAYBE_CloseSourceBrowserDuringDrag DISABLED_CloseSourceBrowserDuringDrag

#else