chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc - Issue 796253002: Fix use-after-free when browser is closed during a drop-drop on desktop Linux

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc

Issue 796253002: Fix use-after-free when browser is closed during a drop-drop on desktop Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc » ('j') | ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/bind.h"	5 #include "base/bind.h"

6 #include "base/callback.h"	6 #include "base/callback.h"

7 #include "base/compiler_specific.h"	7 #include "base/compiler_specific.h"

8 #include "base/prefs/pref_service.h"	8 #include "base/prefs/pref_service.h"

9 #include "base/strings/string_number_conversions.h"	9 #include "base/strings/string_number_conversions.h"

10 #include "base/strings/utf_string_conversions.h"	10 #include "base/strings/utf_string_conversions.h"

(...skipping 2039 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2050 ui_controls::SendMouseEventsNotifyWhenDone(	2050 ui_controls::SendMouseEventsNotifyWhenDone(

2051 ui_controls::LEFT, ui_controls::UP,	2051 ui_controls::LEFT, ui_controls::UP,

2052 CreateEventTask(this, &BookmarkBarViewTest22::Done));	2052 CreateEventTask(this, &BookmarkBarViewTest22::Done));

2053 #else	2053 #else

2054 // There are no widgets to send the mouse release to.	2054 // There are no widgets to send the mouse release to.

2055 Done();	2055 Done();

2056 #endif	2056 #endif

2057 }	2057 }

2058 };	2058 };

2059	2059

2060 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)	2060 #if defined(OS_WIN)

2061 // TODO(pkotwicz): Enable on Desktop Linux once crbug.com/438365 is fixed.

2062 #define MAYBE_CloseSourceBrowserDuringDrag DISABLED_CloseSourceBrowserDuringDrag

2063 #elif defined(OS_WIN)

2064 // This test times out on Windows. TODO(pkotwicz): Find out why.	2061 // This test times out on Windows. TODO(pkotwicz): Find out why.

2065 #define MAYBE_CloseSourceBrowserDuringDrag DISABLED_CloseSourceBrowserDuringDrag	2062 #define MAYBE_CloseSourceBrowserDuringDrag DISABLED_CloseSourceBrowserDuringDrag

2066 #else	2063 #else

2067 #define MAYBE_CloseSourceBrowserDuringDrag CloseSourceBrowserDuringDrag	2064 #define MAYBE_CloseSourceBrowserDuringDrag CloseSourceBrowserDuringDrag

2068 #endif	2065 #endif

2069	2066

2070 VIEW_TEST(BookmarkBarViewTest22, MAYBE_CloseSourceBrowserDuringDrag)	2067 VIEW_TEST(BookmarkBarViewTest22, MAYBE_CloseSourceBrowserDuringDrag)

OLD	NEW