Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 796223002: OOP PDF: Hide the loading indicator until the plugin loads. (Closed)

Created:
6 years ago by Sam McNally
Modified:
6 years ago
Reviewers:
raymes
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

OOP PDF: Hide the loading indicator until the plugin loads. Previously if the PDF plugin is disabled or click-to-play, the loading indicator appeared over the click-to-play overlay. This hides the loading indicator until a message is received from the plugin. BUG=441132 Committed: https://crrev.com/3d8aa0881d7de3b3ba8e3daea2478015cc429662 Cr-Commit-Position: refs/heads/master@{#308303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/pdf/index.css View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sam McNally
6 years ago (2014-12-12 02:55:40 UTC) #2
raymes
lgtm
6 years ago (2014-12-14 23:53:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796223002/1
6 years ago (2014-12-14 23:55:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 00:52:27 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-15 00:53:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d8aa0881d7de3b3ba8e3daea2478015cc429662
Cr-Commit-Position: refs/heads/master@{#308303}

Powered by Google App Engine
This is Rietveld 408576698