chrome/browser/resources/pdf/pdf.js - Issue 796223002: OOP PDF: Hide the loading indicator until the plugin loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/pdf.js

Issue 796223002: OOP PDF: Hide the loading indicator until the plugin loads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/pdf/pdf.js

diff --git a/chrome/browser/resources/pdf/pdf.js b/chrome/browser/resources/pdf/pdf.js

index 57b80c35179b1f14b2f566f7ef64464aaa848faf..44c0262541a983254d39948cd9d32dadeb81364f 100644

--- a/chrome/browser/resources/pdf/pdf.js

+++ b/chrome/browser/resources/pdf/pdf.js

@@ -402,6 +402,7 @@ PDFViewer.prototype = {

case 'setTranslatedStrings':

this.passwordScreen_.text = message.data.getPasswordString;

this.progressBar_.text = message.data.loadingString;

+ this.progressBar_.style.visibility = 'visible';

this.errorScreen_.text = message.data.loadFailedString;

break;

case 'cancelStreamUrl':

« no previous file with comments | « chrome/browser/resources/pdf/index.css ('k') | no next file » | no next file with comments »