Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: content/browser/child_process_launcher.cc

Issue 796163003: Android: Remove some extra CHECKs() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/child_process_launcher.cc
diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc
index 5f708b87922e918ab1a75b6433e8b12fc6a1106e..e284de561fbf5358b194fcd8e3aaa5dba91ef226 100644
--- a/content/browser/child_process_launcher.cc
+++ b/content/browser/child_process_launcher.cc
@@ -184,12 +184,6 @@ void ChildProcessLauncher::Context::Launch(
// We currently only support renderer and gpu child processes.
std::string process_type =
cmd_line->GetSwitchValueASCII(switches::kProcessType);
- CHECK_NE(switches::kPluginProcess, process_type);
- CHECK_NE(switches::kPpapiBrokerProcess, process_type);
- CHECK_NE(switches::kPpapiPluginProcess, process_type);
- CHECK_NE(switches::kSandboxIPCProcess, process_type);
- CHECK_NE(switches::kUtilityProcess, process_type);
- CHECK_NE(switches::kZygoteProcess, process_type);
Feng Qian 2014/12/12 18:29:42 Should we log the unknown process type on Java-sid
no sievers 2014/12/12 18:50:44 If we want to log we can do that here as well, i.e
Feng Qian 2014/12/12 19:07:31 Sounds good to me, can you add the process type to
CHECK(process_type == switches::kGpuProcess ||
process_type == switches::kRendererProcess);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698