Android: Remove some extra CHECKs()

content/browser/child_process_launcher.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/child_process_launcher.h"
 
 #include <utility>  // For std::pair.
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 166 matching lines @@
     base::CommandLine* cmd_line,
     int child_process_id,
     Client* client) {
   CHECK(BrowserThread::GetCurrentThreadIdentifier(&client_thread_id_));
   client_ = client;
 
 #if defined(OS_ANDROID)
   // We currently only support renderer and gpu child processes.
   std::string process_type =
       cmd_line->GetSwitchValueASCII(switches::kProcessType);
-  CHECK_NE(switches::kPluginProcess, process_type);
-  CHECK_NE(switches::kPpapiBrokerProcess, process_type);
-  CHECK_NE(switches::kPpapiPluginProcess, process_type);
-  CHECK_NE(switches::kSandboxIPCProcess, process_type);
-  CHECK_NE(switches::kUtilityProcess, process_type);
-  CHECK_NE(switches::kZygoteProcess, process_type);

[Feng Qian, 2014/12/12 18:29:42]

Should we log the unknown process type on Java-side instead of 'assert false'
there? If that happens, we will know what new process type is.

[no sievers, 2014/12/12 18:50:44]

If we want to log we can do that here as well, i.e. 
  CHECK(process_type == switches::kGpuProcess ||    process_type ==
switches::kRendererProcess) << "Unsupported process type" << process_type;

Also note that the call stack here has the original process launch site.The
latter task that has the java assert() is posted as a separate task.

[Feng Qian, 2014/12/12 19:07:31]

Sounds good to me, can you add the process type to log here?

   CHECK(process_type == switches::kGpuProcess ||
         process_type == switches::kRendererProcess);
 
   // We need to close the client end of the IPC channel to reliably detect
   // child termination. We will close this fd after we create the child
   // process which is asynchronous on Android.
   ipcfd_.reset(delegate->TakeIpcFd().release());
 #endif
   BrowserThread::PostTask(
       BrowserThread::PROCESS_LAUNCHER, FROM_HERE,
@@ skipping 403 matching lines @@
   context_->SetProcessBackgrounded(background);
 }
 
 void ChildProcessLauncher::SetTerminateChildOnShutdown(
     bool terminate_on_shutdown) {
   if (context_.get())
     context_->set_terminate_child_on_shutdown(terminate_on_shutdown);
 }
 
 }  // namespace content