Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 796063007: separate out the scaline-choosing to simplify chooseProcs (Closed)

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

separate out the scaline-choosing to simplify chooseProcs BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/26feeba2678e82ada6ee0c5096a95a8ef2a00c60

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M src/core/SkBitmapProcState.h View 1 chunk +1 line, -0 lines 1 comment Download
M src/core/SkBitmapProcState.cpp View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
reed1
5 years, 11 months ago (2015-01-14 19:00:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796063007/1
5 years, 11 months ago (2015-01-14 19:00:55 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-14 19:00:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796063007/1
5 years, 11 months ago (2015-01-14 20:28:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/26feeba2678e82ada6ee0c5096a95a8ef2a00c60
5 years, 11 months ago (2015-01-14 20:28:26 UTC) #9
robertphillips
5 years, 11 months ago (2015-01-14 21:54:21 UTC) #10
Message was sent while issue was closed.
lgtm + a dox/naming suggestion

https://codereview.chromium.org/796063007/diff/1/src/core/SkBitmapProcState.h
File src/core/SkBitmapProcState.h (right):

https://codereview.chromium.org/796063007/diff/1/src/core/SkBitmapProcState.h...
src/core/SkBitmapProcState.h:137: bool chooseProcs(const SkMatrix& inv, const
SkPaint&);
clampClamp -> clampInBothDirs ?

Powered by Google App Engine
This is Rietveld 408576698