Issue 796063005: Don't override private PasswordStore::WrapModificationTask without a reason.

Issue 796063005: Don't override private PasswordStore::WrapModificationTask without a reason. (Closed)

Created:
5 years, 11 months ago by vasilii

Modified:
5 years, 11 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Don't override private PasswordStore::WrapModificationTask without a reason. Committed: https://crrev.com/9c944bd89fe5f3c0ffd5a22cfadd517f64af27ba Cr-Commit-Position: refs/heads/master@{#311483}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -6 lines)			Patch
M	components/password_manager/core/browser/password_store.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/password_manager/core/browser/test_password_store.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/password_manager/core/browser/test_password_store.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

vabr (Chromium)

LGTM, as long as the test run OK. Thanks for splitting this from the previous ...

5 years, 11 months ago (2015-01-14 14:58:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796063005/1

5 years, 11 months ago (2015-01-14 15:56:30 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-14 16:01:31 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9c944bd89fe5f3c0ffd5a22cfadd517f64af27ba
Cr-Commit-Position: refs/heads/master@{#311483}