components/password_manager/core/browser/password_store.h - Issue 796063005: Don't override private PasswordStore::WrapModificationTask without a reason.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 796063005: Don't override private PasswordStore::WrapModificationTask without a reason. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/password_manager/core/browser/password_store.h

diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h

index b678368cbaa3b742ae3af142ca3a8bdb859b4872..75495acd46dad9675c700bf6592227155b9e3589 100644

--- a/components/password_manager/core/browser/password_store.h

+++ b/components/password_manager/core/browser/password_store.h

@@ -275,7 +275,7 @@ class PasswordStore : protected PasswordStoreSync,

// observers that the password store may have been modified via

// NotifyLoginsChanged(). Note that there is no guarantee that the called

// method will actually modify the password store data.

- virtual void WrapModificationTask(ModificationTask task);

+ void WrapModificationTask(ModificationTask task);

// Copies |matched_forms| into the request's result vector, then calls

// |ForwardLoginsResult|. Temporarily used as an adapter between the API of

« no previous file with comments | « no previous file | components/password_manager/core/browser/test_password_store.h » ('j') | no next file with comments »