Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 796053002: Revert of Make gclient ready for the Blink (DEPS to main project) transition (Closed)

Created:
6 years ago by Primiano Tucci (use gerrit)
Modified:
6 years ago
CC:
jochen (gone - plz use gerrit), chromium-reviews, cmp-cc_chromium.org, Dirk Pranke, iannucci+depot_tools_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Revert of Make gclient ready for the Blink (DEPS to main project) transition (patchset #6 id:180001 of https://codereview.chromium.org/743083002/) Reason for revert: The test intoruced is flake (see crrev.com/753543006/). Need to look into that with more patience as it reproduces only on precise. Original issue's description: > Make gclient ready for the Blink (DEPS to main project) transition > > This CL makes gclient understand correctly whether a git project is > being moved from DEPS to an upper project and vice-versa. > The driving use case for this is the upcoming Blink merge, where > third_party/Webkit will be removed from DEPS (and .gitignore) and will > become part of the main project. > > At present state, gclient leaves the .git folder around when a project > is removed from DEPS, and that causes many problems. > > Furthermore this CL solves the performance problem of bisecting across > the merge point. The subproject's (Blink) .git/ folder is moved to a > backup location (in the main checkout root) and is restored when moving > backwards, avoiding a re-fetch when bisecting across the merge point. > > BUG=431469 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293329 TBR=iannucci@chromium.org,maruel@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true BUG=431469 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293352

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -241 lines) Patch
M gclient.py View 2 chunks +9 lines, -40 lines 0 comments Download
M gclient_scm.py View 2 chunks +0 lines, -20 lines 0 comments Download
M scm.py View 1 chunk +0 lines, -10 lines 0 comments Download
M testing_support/fake_repos.py View 1 chunk +0 lines, -34 lines 0 comments Download
M tests/gclient_scm_test.py View 3 chunks +0 lines, -4 lines 0 comments Download
M tests/gclient_smoketest.py View 2 chunks +1 line, -131 lines 0 comments Download
M tests/scm_unittest.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Primiano Tucci (use gerrit)
Created Revert of Make gclient ready for the Blink (DEPS to main project) transition
6 years ago (2014-12-11 17:22:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/796053002/1
6 years ago (2014-12-11 17:23:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=293352
6 years ago (2014-12-11 17:25:30 UTC) #3
M-A Ruel
lgtm interestingly https://codereview.chromium.org/797523002/ committed just fine (!?)
6 years ago (2014-12-11 18:29:59 UTC) #4
Primiano Tucci (use gerrit)
6 years ago (2014-12-15 13:25:20 UTC) #5
Message was sent while issue was closed.
On 2014/12/11 18:29:59, M-A Ruel wrote:
> lgtm
> 
> interestingly https://codereview.chromium.org/797523002/ committed just fine
> (!?)

Mumble. That should NOT have worked on precise (which has git 1.7).
I tried to repro locally on a 12.04 and with git 1.7 it systematically fails.
Can somebody confirm which git --version is run by the CQ?
I will start a thread on infra-dev soon about that.

Powered by Google App Engine
This is Rietveld 408576698