do not send traffic to localhost through proxy for android

net/proxy/proxy_config_service_android.cc

Index: net/proxy/proxy_config_service_android.cc
diff --git a/net/proxy/proxy_config_service_android.cc b/net/proxy/proxy_config_service_android.cc
index 50407fe21b7b44dd923730b2f948ab1e0b84efc8..e51f67038419756cbedd5c56d6241283461fab82 100644
--- a/net/proxy/proxy_config_service_android.cc
+++ b/net/proxy/proxy_config_service_android.cc
@@ -98,6 +98,15 @@ void AddBypassRules(const std::string& scheme,
   // by | and that use * as a wildcard. For example, setting the
   // http.nonProxyHosts property to *.android.com|*.kernel.org will cause
   // requests to http://developer.android.com to be made without a proxy.
+
+  // There is no reasonable way to configure localhost
+  // to not go through the proxy. The Linux version of
+  // proxy_config_service does, just not the android

[Torne, 2014/12/11 17:44:49]

Describing the reason why a change was made doesn't belong in a comment in the
actual code; if a comment is needed at all it should explain the state of things
*after the change*.

+  // version. As sending communication to localhost through
+  // the proxy is silly, we force a bypass rule for
+  // localhost, causing it to never go through the proxy.
+  bypass_rules->AddRuleToBypassLocal();
+
   std::string non_proxy_hosts =
       get_property.Run(scheme + ".nonProxyHosts");
   if (non_proxy_hosts.empty())