do not send traffic to localhost through proxy for android

net/proxy/proxy_config_service_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_config_service_android.h"
 
 #include <sys/system_properties.h>
 
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
@@ skipping 80 matching lines @@
   return ProxyServer();
 }
 
 void AddBypassRules(const std::string& scheme,
                     const GetPropertyCallback& get_property,
                     ProxyBypassRules* bypass_rules) {
   // The format of a hostname pattern is a list of hostnames that are separated
   // by | and that use * as a wildcard. For example, setting the
   // http.nonProxyHosts property to *.android.com|*.kernel.org will cause
   // requests to http://developer.android.com to be made without a proxy.
+
+  // There is no reasonable way to configure localhost
+  // to not go through the proxy. The Linux version of
+  // proxy_config_service does, just not the android

[Torne, 2014/12/11 17:44:49]

Describing the reason why a change was made doesn't belong in a comment in the
actual code; if a comment is needed at all it should explain the state of things
*after the change*.

+  // version. As sending communication to localhost through
+  // the proxy is silly, we force a bypass rule for
+  // localhost, causing it to never go through the proxy.
+  bypass_rules->AddRuleToBypassLocal();
+
   std::string non_proxy_hosts =
       get_property.Run(scheme + ".nonProxyHosts");
   if (non_proxy_hosts.empty())
     return;
   base::StringTokenizer tokenizer(non_proxy_hosts, "|");
   while (tokenizer.GetNext()) {
     std::string token = tokenizer.token();
     std::string pattern;
     base::TrimWhitespaceASCII(token, base::TRIM_ALL, &pattern);
     if (pattern.empty())
@@ skipping 291 matching lines @@
         network_task_runner, jni_task_runner, get_property_callback)) {
   delegate_->SetupJNI();
   delegate_->FetchInitialConfig();
 }
 
 void ProxyConfigServiceAndroid::ProxySettingsChanged() {
   delegate_->ProxySettingsChanged();
 }
 
 } // namespace net