Enable webview-based sign-in to chrome.

Enable webview-based sign-in to chrome.

BUG=441821
Committed: https://crrev.com/334d803793e5b4d5c8cce15fbf9efdec3223364a
Cr-Commit-Position: refs/heads/master@{#310404}

[Roger Tawa OOO till Jul 10th, 2014-12-12 18:23:35]

rogerta@chromium.org changed reviewers:
+ noms@chromium.org

[Roger Tawa OOO till Jul 10th, 2014-12-12 18:23:35]

Hi Monica,

Please take a look.  Thanks.

[noms (inactive), 2014-12-12 18:28:54]

lgtm

https://codereview.chromium.org/795873004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/795873004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:14085: +        When enabled, will use an
iframe-based Chrome sign-in flow.  Otherwise uses a webview-based flow.
nit: maybe change the period into a semicolon. "...Chrome sign-in flow;
otherwise, uses..."

[Roger Tawa OOO till Jul 10th, 2014-12-15 23:09:46]

Patchset #4 (id:60001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:42:00]

Patchset #4 (id:80001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:42:12]

Patchset #4 (id:100001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:42:21]

Patchset #4 (id:120001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:42:29]

Patchset #4 (id:140001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:42:37]

Patchset #4 (id:160001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:42:46]

Patchset #4 (id:180001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:42:54]

Patchset #4 (id:200001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:43:03]

Patchset #4 (id:220001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:43:12]

Patchset #4 (id:240001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:43:20]

Patchset #4 (id:260001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:43:28]

Patchset #4 (id:280001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:43:38]

Patchset #4 (id:300001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:46:24]

Patchset #3 (id:40001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:46:38]

Patchset #3 (id:320001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:47:04]

Patchset #3 (id:340001) has been deleted

[Roger Tawa OOO till Jul 10th, 2015-01-07 20:49:25]

Hi Monica,

Most of the fixes in this CL were moved to
https://codereview.chromium.org/807503004/, which is now already committed.  So
this CL only contains the changes need to enable the feature.  You already
lgtm'ed a while ago, but please take another look.  Thanks.

https://codereview.chromium.org/795873004/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/795873004/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:14085: +        When enabled, will use an
iframe-based Chrome sign-in flow.  Otherwise uses a webview-based flow.
On 2014/12/12 18:28:53, Monica Dinculescu wrote:
> nit: maybe change the period into a semicolon. "...Chrome sign-in flow;
> otherwise, uses..."

Done.

[noms (inactive), 2015-01-07 21:01:14]

still lgtm

[Roger Tawa OOO till Jul 10th, 2015-01-07 21:02:23]

rogerta@chromium.org changed reviewers:
+ jwd@chromium.org

[Roger Tawa OOO till Jul 10th, 2015-01-07 21:02:23]

Hi Jesse,

Can you review the histograms file please?  Thanks.

[Roger Tawa OOO till Jul 10th, 2015-01-07 22:01:34]

rogerta@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Roger Tawa OOO till Jul 10th, 2015-01-07 22:01:34]

Hi Alexei,

Please take a look at histograms.xml.  Thanks.

[Alexei Svitkine (slow), 2015-01-07 22:03:20]

histograms lgtm % comment

https://codereview.chromium.org/795873004/diff/420001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/795873004/diff/420001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:49814: -  <int value="-1872989945"
label="enable-webview-based-signin"/>
Please don't remove this entry as it's useful for decoding data from old
versions.

[Roger Tawa OOO till Jul 10th, 2015-01-07 22:09:39]

Thanks Alexei.  Put the old value back.

https://codereview.chromium.org/795873004/diff/420001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/795873004/diff/420001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:49814: -  <int value="-1872989945"
label="enable-webview-based-signin"/>
On 2015/01/07 22:03:20, Alexei Svitkine wrote:
> Please don't remove this entry as it's useful for decoding data from old
> versions.

Done.

[Roger Tawa OOO till Jul 10th, 2015-01-07 22:10:01]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2015-01-07 22:10:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/795873004/440001

[commit-bot: I haz the power, 2015-01-07 23:10:55]

Committed patchset #7 (id:440001)

[commit-bot: I haz the power, 2015-01-07 23:12:50]

Patchset 7 (id:??) landed as
https://crrev.com/334d803793e5b4d5c8cce15fbf9efdec3223364a
Cr-Commit-Position: refs/heads/master@{#310404}