chrome/browser/about_flags.cc - Issue 795873004: Enable webview-based sign-in to chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/about_flags.cc

Issue 795873004: Enable webview-based sign-in to chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Put back old value and label in histograms Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/about_flags.cc

diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc

index 713f97b545ee5e6ce29fecefc0bb3579436fe104..96d6358ba32396c6cf95b299244c6dbe523630c0 100644

--- a/chrome/browser/about_flags.cc

+++ b/chrome/browser/about_flags.cc

@@ -1413,11 +1413,11 @@ const Experiment kExperiments[] = {

SINGLE_VALUE_TYPE(switches::kEnableWebBasedSignin)

{

- "enable-webview-based-signin",

- IDS_FLAGS_ENABLE_WEBVIEW_BASED_SIGNIN_NAME,

- IDS_FLAGS_ENABLE_WEBVIEW_BASED_SIGNIN_DESCRIPTION,

+ "enable-iframe-based-signin",

+ IDS_FLAGS_ENABLE_IFRAME_BASED_SIGNIN_NAME,

+ IDS_FLAGS_ENABLE_IFRAME_BASED_SIGNIN_DESCRIPTION,

kOsMac | kOsWin | kOsLinux,

- SINGLE_VALUE_TYPE(switches::kEnableWebviewBasedSignin)

+ SINGLE_VALUE_TYPE(switches::kEnableIframeBasedSignin)

{

"enable-google-profile-info",