Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp

Issue 795833004: Use dictionaries for context creation attributes. Eliminate custom bindings. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/WrapCanvasContext.cpp ('k') | Source/bindings/core/v8/v8.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp
index feea30cfbb84294e98660814cedf22661ba336d9..990ff1265e7f04923792b82bbddb9ca8374574fb 100644
--- a/Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8HTMLCanvasElementCustom.cpp
@@ -47,88 +47,6 @@
namespace blink {
-void V8HTMLCanvasElement::getContextMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
- v8::Handle<v8::Object> holder = info.Holder();
- v8::Isolate* isolate = info.GetIsolate();
- HTMLCanvasElement* impl = V8HTMLCanvasElement::toImpl(holder);
- TOSTRING_VOID(V8StringResource<>, contextIdResource, info[0]);
- String contextId = contextIdResource;
- RefPtrWillBeRawPtr<CanvasContextAttributes> attributes = nullptr;
- if (contextId == "webgl" || contextId == "experimental-webgl") {
- RefPtrWillBeRawPtr<WebGLContextAttributes> webGLAttributes = WebGLContextAttributes::create();
- if (info.Length() > 1 && info[1]->IsObject()) {
- v8::Handle<v8::Object> jsAttributes = info[1]->ToObject(isolate);
- v8::Handle<v8::String> alpha = v8AtomicString(isolate, "alpha");
- if (jsAttributes->Has(alpha) && !isUndefinedOrNull(jsAttributes->Get(alpha)))
- webGLAttributes->setAlpha(jsAttributes->Get(alpha)->BooleanValue());
- v8::Handle<v8::String> depth = v8AtomicString(isolate, "depth");
- if (jsAttributes->Has(depth) && !isUndefinedOrNull(jsAttributes->Get(depth)))
- webGLAttributes->setDepth(jsAttributes->Get(depth)->BooleanValue());
- v8::Handle<v8::String> stencil = v8AtomicString(isolate, "stencil");
- if (jsAttributes->Has(stencil) && !isUndefinedOrNull(jsAttributes->Get(stencil)))
- webGLAttributes->setStencil(jsAttributes->Get(stencil)->BooleanValue());
- v8::Handle<v8::String> antialias = v8AtomicString(isolate, "antialias");
- if (jsAttributes->Has(antialias) && !isUndefinedOrNull(jsAttributes->Get(antialias)))
- webGLAttributes->setAntialias(jsAttributes->Get(antialias)->BooleanValue());
- v8::Handle<v8::String> premultipliedAlpha = v8AtomicString(isolate, "premultipliedAlpha");
- if (jsAttributes->Has(premultipliedAlpha) && !isUndefinedOrNull(jsAttributes->Get(premultipliedAlpha)))
- webGLAttributes->setPremultipliedAlpha(jsAttributes->Get(premultipliedAlpha)->BooleanValue());
- v8::Handle<v8::String> preserveDrawingBuffer = v8AtomicString(isolate, "preserveDrawingBuffer");
- if (jsAttributes->Has(preserveDrawingBuffer) && !isUndefinedOrNull(jsAttributes->Get(preserveDrawingBuffer)))
- webGLAttributes->setPreserveDrawingBuffer(jsAttributes->Get(preserveDrawingBuffer)->BooleanValue());
- v8::Handle<v8::String> failIfMajorPerformanceCaveat = v8AtomicString(isolate, "failIfMajorPerformanceCaveat");
- if (jsAttributes->Has(failIfMajorPerformanceCaveat) && !isUndefinedOrNull(jsAttributes->Get(failIfMajorPerformanceCaveat)))
- webGLAttributes->setFailIfMajorPerformanceCaveat(jsAttributes->Get(failIfMajorPerformanceCaveat)->BooleanValue());
- }
- attributes = webGLAttributes;
- } else {
- RefPtrWillBeRawPtr<Canvas2DContextAttributes> canvas2DAttributes = Canvas2DContextAttributes::create();
- if (info.Length() > 1 && info[1]->IsObject()) {
- v8::Handle<v8::Object> jsAttributes = info[1]->ToObject(isolate);
- v8::Handle<v8::String> alpha = v8AtomicString(isolate, "alpha");
- if (jsAttributes->Has(alpha) && !isUndefinedOrNull(jsAttributes->Get(alpha)))
- canvas2DAttributes->setAlpha(jsAttributes->Get(alpha)->BooleanValue());
- }
- attributes = canvas2DAttributes;
- }
- CanvasRenderingContext* result = impl->getContext(contextId, attributes.get());
- if (!result) {
- v8SetReturnValueNull(info);
- return;
- }
- if (result->is2d()) {
- v8::Handle<v8::Value> v8Result = toV8(toCanvasRenderingContext2D(result), info.Holder(), info.GetIsolate());
- if (InspectorInstrumentation::canvasAgentEnabled(&impl->document())) {
- ScriptState* scriptState = ScriptState::current(isolate);
- ScriptValue context(scriptState, v8Result);
- ScriptValue wrapped = InspectorInstrumentation::wrapCanvas2DRenderingContextForInstrumentation(&impl->document(), context);
- if (!wrapped.isEmpty()) {
- v8SetReturnValue(info, wrapped.v8Value());
- return;
- }
- }
- v8SetReturnValue(info, v8Result);
- return;
- }
- if (result->is3d()) {
- v8::Handle<v8::Value> v8Result = toV8(toWebGLRenderingContext(result), info.Holder(), info.GetIsolate());
- if (InspectorInstrumentation::canvasAgentEnabled(&impl->document())) {
- ScriptState* scriptState = ScriptState::current(isolate);
- ScriptValue glContext(scriptState, v8Result);
- ScriptValue wrapped = InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation(&impl->document(), glContext);
- if (!wrapped.isEmpty()) {
- v8SetReturnValue(info, wrapped.v8Value());
- return;
- }
- }
- v8SetReturnValue(info, v8Result);
- return;
- }
- ASSERT_NOT_REACHED();
- v8SetReturnValueNull(info);
-}
-
void V8HTMLCanvasElement::toDataURLMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
{
v8::Handle<v8::Object> holder = info.Holder();
« no previous file with comments | « Source/bindings/core/v8/WrapCanvasContext.cpp ('k') | Source/bindings/core/v8/v8.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698