Issue 795783002: Revert of Fix to set correct output type when blending when we've read dst

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 795783002: Revert of Fix to set correct output type when blending when we've read dst (Closed)

Created:
6 years ago by joshualitt

Modified:
6 years ago

Reviewers:
bsalomon, egdaniel

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Fix to set correct output type when blending when we've read dst (patchset #4 id:60001 of https://codereview.chromium.org/791143002/) Reason for revert: Breaks DM on windows Original issue's description: > Fix to set correct output type when blending when we've read dst > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/733fc2054044377e914559fa4f46db66ab7d9cea TBR=bsalomon@google.com,egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/06f019fc0f809db993b03d7beb2fd5b4e0c58160

Created: 6 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -21 lines)			Patch
	M	include/gpu/effects/GrPorterDuffXferProcessor.h	View		4 chunks	+0 lines, -11 lines	0 comments	Download
	M	src/gpu/effects/GrPorterDuffXferProcessor.cpp	View		4 chunks	+0 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

joshualitt

Created Revert of Fix to set correct output type when blending when we've read dst

6 years ago (2014-12-10 22:56:33 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795783002/1

6 years ago (2014-12-10 22:57:45 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-10 22:57:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/06f019fc0f809db993b03d7beb2fd5b4e0c58160