Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: include/gpu/effects/GrPorterDuffXferProcessor.h

Issue 795783002: Revert of Fix to set correct output type when blending when we've read dst (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/gpu/effects/GrPorterDuffXferProcessor.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef GrPorterDuffXferProcessor_DEFINED 8 #ifndef GrPorterDuffXferProcessor_DEFINED
9 #define GrPorterDuffXferProcessor_DEFINED 9 #define GrPorterDuffXferProcessor_DEFINED
10 10
(...skipping 18 matching lines...) Expand all
29 void getGLProcessorKey(const GrGLCaps& caps, GrProcessorKeyBuilder* b) const SK_OVERRIDE; 29 void getGLProcessorKey(const GrGLCaps& caps, GrProcessorKeyBuilder* b) const SK_OVERRIDE;
30 30
31 GrGLXferProcessor* createGLInstance() const SK_OVERRIDE; 31 GrGLXferProcessor* createGLInstance() const SK_OVERRIDE;
32 32
33 virtual bool hasSecondaryOutput() const SK_OVERRIDE; 33 virtual bool hasSecondaryOutput() const SK_OVERRIDE;
34 34
35 /////////////////////////////////////////////////////////////////////////// 35 ///////////////////////////////////////////////////////////////////////////
36 /// @name Stage Output Types 36 /// @name Stage Output Types
37 //// 37 ////
38 38
39 enum PrimaryOutputType {
40 // Modulate color and coverage, write result as the color output.
41 kModulate_PrimaryOutputType,
42 // Combines the coverage, dst, and color as coverage * color + (1 - cove rage) * dst. This
43 // can only be set if fDstReadKey is non-zero.
44 kCombineWithDst_PrimaryOutputType,
45 };
46
47 enum SecondaryOutputType { 39 enum SecondaryOutputType {
48 // There is no secondary output 40 // There is no secondary output
49 kNone_SecondaryOutputType, 41 kNone_SecondaryOutputType,
50 // Writes coverage as the secondary output. Only set if dual source blen ding is supported 42 // Writes coverage as the secondary output. Only set if dual source blen ding is supported
51 // and primary output is kModulate. 43 // and primary output is kModulate.
52 kCoverage_SecondaryOutputType, 44 kCoverage_SecondaryOutputType,
53 // Writes coverage * (1 - colorA) as the secondary output. Only set if d ual source blending 45 // Writes coverage * (1 - colorA) as the secondary output. Only set if d ual source blending
54 // is supported and primary output is kModulate. 46 // is supported and primary output is kModulate.
55 kCoverageISA_SecondaryOutputType, 47 kCoverageISA_SecondaryOutputType,
56 // Writes coverage * (1 - colorRGBA) as the secondary output. Only set i f dual source 48 // Writes coverage * (1 - colorRGBA) as the secondary output. Only set i f dual source
57 // blending is supported and primary output is kModulate. 49 // blending is supported and primary output is kModulate.
58 kCoverageISC_SecondaryOutputType, 50 kCoverageISC_SecondaryOutputType,
59 51
60 kSecondaryOutputTypeCnt, 52 kSecondaryOutputTypeCnt,
61 }; 53 };
62 54
63 PrimaryOutputType primaryOutputType() const { return fPrimaryOutputType; }
64 SecondaryOutputType secondaryOutputType() const { return fSecondaryOutputTyp e; } 55 SecondaryOutputType secondaryOutputType() const { return fSecondaryOutputTyp e; }
65 56
66 GrXferProcessor::OptFlags getOptimizations(const GrProcOptInfo& colorPOI, 57 GrXferProcessor::OptFlags getOptimizations(const GrProcOptInfo& colorPOI,
67 const GrProcOptInfo& coveragePOI, 58 const GrProcOptInfo& coveragePOI,
68 bool isCoverageDrawing, 59 bool isCoverageDrawing,
69 bool colorWriteDisabled, 60 bool colorWriteDisabled,
70 bool doesStencilWrite, 61 bool doesStencilWrite,
71 GrColor* color, 62 GrColor* color,
72 uint8_t* coverage, 63 uint8_t* coverage,
73 const GrDrawTargetCaps& caps) SK_ OVERRIDE; 64 const GrDrawTargetCaps& caps) SK_ OVERRIDE;
74 65
75 void getBlendInfo(GrXferProcessor::BlendInfo* blendInfo) const SK_OVERRIDE { 66 void getBlendInfo(GrXferProcessor::BlendInfo* blendInfo) const SK_OVERRIDE {
76 blendInfo->fSrcBlend = fSrcBlend; 67 blendInfo->fSrcBlend = fSrcBlend;
77 blendInfo->fDstBlend = fDstBlend; 68 blendInfo->fDstBlend = fDstBlend;
78 blendInfo->fBlendConstant = fBlendConstant; 69 blendInfo->fBlendConstant = fBlendConstant;
79 } 70 }
80 71
81 private: 72 private:
82 GrPorterDuffXferProcessor(GrBlendCoeff srcBlend, GrBlendCoeff dstBlend, GrCo lor constant); 73 GrPorterDuffXferProcessor(GrBlendCoeff srcBlend, GrBlendCoeff dstBlend, GrCo lor constant);
83 74
84 bool onIsEqual(const GrXferProcessor& xpBase) const SK_OVERRIDE { 75 bool onIsEqual(const GrXferProcessor& xpBase) const SK_OVERRIDE {
85 const GrPorterDuffXferProcessor& xp = xpBase.cast<GrPorterDuffXferProces sor>(); 76 const GrPorterDuffXferProcessor& xp = xpBase.cast<GrPorterDuffXferProces sor>();
86 if (fSrcBlend != xp.fSrcBlend || 77 if (fSrcBlend != xp.fSrcBlend ||
87 fDstBlend != xp.fDstBlend || 78 fDstBlend != xp.fDstBlend ||
88 fBlendConstant != xp.fBlendConstant || 79 fBlendConstant != xp.fBlendConstant ||
89 fPrimaryOutputType != xp.fPrimaryOutputType ||
90 fSecondaryOutputType != xp.fSecondaryOutputType) { 80 fSecondaryOutputType != xp.fSecondaryOutputType) {
91 return false; 81 return false;
92 } 82 }
93 return true; 83 return true;
94 } 84 }
95 85
96 void onComputeInvariantOutput(GrInvariantOutput* inout) const SK_OVERRIDE; 86 void onComputeInvariantOutput(GrInvariantOutput* inout) const SK_OVERRIDE;
97 87
98 GrXferProcessor::OptFlags internalGetOptimizations(const GrProcOptInfo& colo rPOI, 88 GrXferProcessor::OptFlags internalGetOptimizations(const GrProcOptInfo& colo rPOI,
99 const GrProcOptInfo& cove ragePOI, 89 const GrProcOptInfo& cove ragePOI,
100 bool isCoverageDrawing, 90 bool isCoverageDrawing,
101 bool colorWriteDisabled, 91 bool colorWriteDisabled,
102 bool doesStencilWrite, 92 bool doesStencilWrite,
103 GrColor* color, 93 GrColor* color,
104 uint8_t* coverage); 94 uint8_t* coverage);
105 95
106 void calcOutputTypes(GrXferProcessor::OptFlags blendOpts, const GrDrawTarget Caps& caps, 96 void calcOutputTypes(GrXferProcessor::OptFlags blendOpts, const GrDrawTarget Caps& caps,
107 bool isCoverageDrawing, bool readDst); 97 bool isCoverageDrawing, bool readDst);
108 98
109 GrBlendCoeff fSrcBlend; 99 GrBlendCoeff fSrcBlend;
110 GrBlendCoeff fDstBlend; 100 GrBlendCoeff fDstBlend;
111 GrColor fBlendConstant; 101 GrColor fBlendConstant;
112 PrimaryOutputType fPrimaryOutputType;
113 SecondaryOutputType fSecondaryOutputType; 102 SecondaryOutputType fSecondaryOutputType;
114 103
115 typedef GrXferProcessor INHERITED; 104 typedef GrXferProcessor INHERITED;
116 }; 105 };
117 106
118 /////////////////////////////////////////////////////////////////////////////// 107 ///////////////////////////////////////////////////////////////////////////////
119 108
120 class GrPorterDuffXPFactory : public GrXPFactory { 109 class GrPorterDuffXPFactory : public GrXPFactory {
121 public: 110 public:
122 static GrXPFactory* Create(SkXfermode::Mode mode); 111 static GrXPFactory* Create(SkXfermode::Mode mode);
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 146
158 GR_DECLARE_XP_FACTORY_TEST; 147 GR_DECLARE_XP_FACTORY_TEST;
159 148
160 GrBlendCoeff fSrcCoeff; 149 GrBlendCoeff fSrcCoeff;
161 GrBlendCoeff fDstCoeff; 150 GrBlendCoeff fDstCoeff;
162 151
163 typedef GrXPFactory INHERITED; 152 typedef GrXPFactory INHERITED;
164 }; 153 };
165 154
166 #endif 155 #endif
OLDNEW
« no previous file with comments | « no previous file | src/gpu/effects/GrPorterDuffXferProcessor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698