Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/typing.cc

Issue 795573005: ES6 computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/runtime/runtime-object.cc ('K') | « src/runtime/runtime-object.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/typing.cc
diff --git a/src/typing.cc b/src/typing.cc
index 3f63237596ae116a6882fab950dbc6a214a73cbc..fd43e53929b50b1f9e878378e1179d1071bcae06 100644
--- a/src/typing.cc
+++ b/src/typing.cc
@@ -407,7 +407,8 @@ void AstTyper::VisitObjectLiteral(ObjectLiteral* expr) {
if ((prop->kind() == ObjectLiteral::Property::MATERIALIZED_LITERAL &&
!CompileTimeValue::IsCompileTimeValue(prop->value())) ||
prop->kind() == ObjectLiteral::Property::COMPUTED) {
- if (prop->key()->value()->IsInternalizedString() && prop->emit_store()) {
+ if (prop->key()->AsLiteral()->value()->IsInternalizedString() &&
arv (Not doing code reviews) 2014/12/10 23:38:13 check is_computed_name here
arv (Not doing code reviews) 2014/12/11 23:10:34 Done.
+ prop->emit_store()) {
prop->RecordTypeFeedback(oracle());
}
}
« src/runtime/runtime-object.cc ('K') | « src/runtime/runtime-object.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698