Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: src/typing.cc

Issue 795573005: ES6 computed property names (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/typing.h" 5 #include "src/typing.h"
6 6
7 #include "src/frames.h" 7 #include "src/frames.h"
8 #include "src/frames-inl.h" 8 #include "src/frames-inl.h"
9 #include "src/ostreams.h" 9 #include "src/ostreams.h"
10 #include "src/parser.h" // for CompileTimeValue; TODO(rossberg): should move 10 #include "src/parser.h" // for CompileTimeValue; TODO(rossberg): should move
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
400 400
401 void AstTyper::VisitObjectLiteral(ObjectLiteral* expr) { 401 void AstTyper::VisitObjectLiteral(ObjectLiteral* expr) {
402 ZoneList<ObjectLiteral::Property*>* properties = expr->properties(); 402 ZoneList<ObjectLiteral::Property*>* properties = expr->properties();
403 for (int i = 0; i < properties->length(); ++i) { 403 for (int i = 0; i < properties->length(); ++i) {
404 ObjectLiteral::Property* prop = properties->at(i); 404 ObjectLiteral::Property* prop = properties->at(i);
405 405
406 // Collect type feedback. 406 // Collect type feedback.
407 if ((prop->kind() == ObjectLiteral::Property::MATERIALIZED_LITERAL && 407 if ((prop->kind() == ObjectLiteral::Property::MATERIALIZED_LITERAL &&
408 !CompileTimeValue::IsCompileTimeValue(prop->value())) || 408 !CompileTimeValue::IsCompileTimeValue(prop->value())) ||
409 prop->kind() == ObjectLiteral::Property::COMPUTED) { 409 prop->kind() == ObjectLiteral::Property::COMPUTED) {
410 if (prop->key()->value()->IsInternalizedString() && prop->emit_store()) { 410 if (prop->key()->AsLiteral()->value()->IsInternalizedString() &&
arv (Not doing code reviews) 2014/12/10 23:38:13 check is_computed_name here
arv (Not doing code reviews) 2014/12/11 23:10:34 Done.
411 prop->emit_store()) {
411 prop->RecordTypeFeedback(oracle()); 412 prop->RecordTypeFeedback(oracle());
412 } 413 }
413 } 414 }
414 415
415 RECURSE(Visit(prop->value())); 416 RECURSE(Visit(prop->value()));
416 } 417 }
417 418
418 NarrowType(expr, Bounds(Type::Object(zone()))); 419 NarrowType(expr, Bounds(Type::Object(zone())));
419 } 420 }
420 421
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 void AstTyper::VisitModuleUrl(ModuleUrl* module) { 806 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
806 } 807 }
807 808
808 809
809 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) { 810 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
810 RECURSE(Visit(stmt->body())); 811 RECURSE(Visit(stmt->body()));
811 } 812 }
812 813
813 814
814 } } // namespace v8::internal 815 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698