Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: extensions/common/permissions/usb_device_permission.h

Issue 795543002: Added PermissionIDSet to APIPermissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_patch_1_static_initializer_fix
Patch Set: Removed unnecessary constructor and added tests for API permissions Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/usb_device_permission.h
diff --git a/extensions/common/permissions/usb_device_permission.h b/extensions/common/permissions/usb_device_permission.h
index cb19f3e937bb81621ea19cdea71f00f8bb2458dc..0a04ec5d7523f8595592afe292f28d5dfe6c8660 100644
--- a/extensions/common/permissions/usb_device_permission.h
+++ b/extensions/common/permissions/usb_device_permission.h
@@ -30,7 +30,14 @@ class UsbDevicePermission
~UsbDevicePermission() override;
// APIPermission overrides
+ PermissionIDSet GetPermissions() const override;
PermissionMessages GetMessages() const override;
+
+ private:
+ // TODO(sashab): Once GetMessages() is deprecated, remove this function and
+ // move all logic back into GetPermissions().
+ void AddPermissionsToLists(PermissionIDSet& ids,
Yoyo Zhou 2014/12/11 00:54:11 Similarly, this could be an anonymous namespace fu
sashab 2014/12/11 04:15:37 Done. Also made it slightly more efficient by taki
+ PermissionMessages& messages) const;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698