Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: extensions/common/permissions/usb_device_permission.h

Issue 795543002: Added PermissionIDSet to APIPermissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_patch_1_static_initializer_fix
Patch Set: Removed unnecessary constructor and added tests for API permissions Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_COMMON_PERMISSIONS_USB_DEVICE_PERMISSION_H_ 5 #ifndef EXTENSIONS_COMMON_PERMISSIONS_USB_DEVICE_PERMISSION_H_
6 #define EXTENSIONS_COMMON_PERMISSIONS_USB_DEVICE_PERMISSION_H_ 6 #define EXTENSIONS_COMMON_PERMISSIONS_USB_DEVICE_PERMISSION_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "extensions/common/permissions/api_permission.h" 9 #include "extensions/common/permissions/api_permission.h"
10 #include "extensions/common/permissions/set_disjunction_permission.h" 10 #include "extensions/common/permissions/set_disjunction_permission.h"
(...skipping 12 matching lines...) Expand all
23 interface_id(interface_id) {} 23 interface_id(interface_id) {}
24 const uint16 vendor_id; 24 const uint16 vendor_id;
25 const uint16 product_id; 25 const uint16 product_id;
26 const int interface_id; 26 const int interface_id;
27 }; 27 };
28 28
29 explicit UsbDevicePermission(const APIPermissionInfo* info); 29 explicit UsbDevicePermission(const APIPermissionInfo* info);
30 ~UsbDevicePermission() override; 30 ~UsbDevicePermission() override;
31 31
32 // APIPermission overrides 32 // APIPermission overrides
33 PermissionIDSet GetPermissions() const override;
33 PermissionMessages GetMessages() const override; 34 PermissionMessages GetMessages() const override;
35
36 private:
37 // TODO(sashab): Once GetMessages() is deprecated, remove this function and
38 // move all logic back into GetPermissions().
39 void AddPermissionsToLists(PermissionIDSet& ids,
Yoyo Zhou 2014/12/11 00:54:11 Similarly, this could be an anonymous namespace fu
sashab 2014/12/11 04:15:37 Done. Also made it slightly more efficient by taki
40 PermissionMessages& messages) const;
34 }; 41 };
35 42
36 } // namespace extensions 43 } // namespace extensions
37 44
38 #endif // EXTENSIONS_COMMON_PERMISSIONS_USB_DEVICE_PERMISSION_H_ 45 #endif // EXTENSIONS_COMMON_PERMISSIONS_USB_DEVICE_PERMISSION_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698