Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: extensions/common/permissions/settings_override_permission.cc

Issue 795543002: Added PermissionIDSet to APIPermissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_patch_1_static_initializer_fix
Patch Set: Removed unnecessary constructor and added tests for API permissions Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/settings_override_permission.cc
diff --git a/extensions/common/permissions/settings_override_permission.cc b/extensions/common/permissions/settings_override_permission.cc
index e23bc2eecc5c2e4fed369d9fc02ccadbba87001e..f71c230ecffceb1ccab662d5c13beabc56583846 100644
--- a/extensions/common/permissions/settings_override_permission.cc
+++ b/extensions/common/permissions/settings_override_permission.cc
@@ -5,6 +5,7 @@
#include "extensions/common/permissions/settings_override_permission.h"
#include "base/strings/utf_string_conversions.h"
+#include "extensions/common/permissions/api_permission_set.h"
#include "grit/extensions_strings.h"
#include "ui/base/l10n/l10n_util.h"
@@ -17,6 +18,12 @@ SettingsOverrideAPIPermission::SettingsOverrideAPIPermission(
SettingsOverrideAPIPermission::~SettingsOverrideAPIPermission() {}
+PermissionIDSet SettingsOverrideAPIPermission::GetPermissions() const {
+ PermissionIDSet permissions;
+ permissions.insert(info()->id(), base::UTF8ToUTF16(setting_value_));
+ return permissions;
+}
+
bool SettingsOverrideAPIPermission::HasMessages() const {
return info()->message_id() > PermissionMessage::kNone;
}
@@ -24,16 +31,26 @@ bool SettingsOverrideAPIPermission::HasMessages() const {
PermissionMessages SettingsOverrideAPIPermission::GetMessages() const {
DCHECK(HasMessages());
int string_id = -1;
+ // Warning: when modifying this function, be sure to modify the correct rule
+ // in ChromePermissionMessageProvider.
switch (id()) {
case kHomepage: {
+ // TODO(sashab): Add a parameter rule in ChromePermissionMessageProvider:
+ // kHomepage -> IDS_EXTENSION_PROMPT_WARNING_HOME_PAGE_SETTING_OVERRIDE
string_id = IDS_EXTENSION_PROMPT_WARNING_HOME_PAGE_SETTING_OVERRIDE;
break;
}
case kStartupPages: {
+ // TODO(sashab): Add a parameter rule in ChromePermissionMessageProvider:
+ // kStartupPages ->
+ // IDS_EXTENSION_PROMPT_WARNING_START_PAGE_SETTING_OVERRIDE
string_id = IDS_EXTENSION_PROMPT_WARNING_START_PAGE_SETTING_OVERRIDE;
break;
}
case kSearchProvider: {
+ // TODO(sashab): Add a parameter rule in ChromePermissionMessageProvider:
+ // kSearchProvider ->
+ // IDS_EXTENSION_PROMPT_WARNING_SEARCH_SETTINGS_OVERRIDE
string_id = IDS_EXTENSION_PROMPT_WARNING_SEARCH_SETTINGS_OVERRIDE;
break;
}

Powered by Google App Engine
This is Rietveld 408576698