Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: extensions/common/permissions/media_galleries_permission.h

Issue 795543002: Added PermissionIDSet to APIPermissions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_patch_1_static_initializer_fix
Patch Set: Removed unnecessary constructor and added tests for API permissions Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/media_galleries_permission.h
diff --git a/extensions/common/permissions/media_galleries_permission.h b/extensions/common/permissions/media_galleries_permission.h
index dfaed1b05f27fe57c35c245e725cebb96308b553..4bc5794f716b5dca8adfaf6fceea6df879a5f228 100644
--- a/extensions/common/permissions/media_galleries_permission.h
+++ b/extensions/common/permissions/media_galleries_permission.h
@@ -43,6 +43,7 @@ class MediaGalleriesPermission
std::vector<std::string>* unhandled_permissions) override;
// APIPermission overrides.
+ PermissionIDSet GetPermissions() const override;
PermissionMessages GetMessages() const override;
// Permission strings.
@@ -51,6 +52,12 @@ class MediaGalleriesPermission
static const char kReadPermission[];
static const char kCopyToPermission[];
static const char kDeletePermission[];
+
+ private:
+ // TODO(sashab): Once GetMessages() is deprecated, move this logic back into
Yoyo Zhou 2014/12/11 00:54:11 nit: seems like this TODO should go in the impleme
sashab 2014/12/11 04:15:36 Done. Also renamed to AddPermissionsToLists() and
+ // GetPermissions().
+ void AddMessagesAndPermissions(PermissionIDSet* permission_ids,
+ PermissionMessages* permission_messages) const;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698