chrome/browser/ui/cocoa/one_click_signin_view_controller.mm - Issue 79553004: Security fix for untrusted signin confirm dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

Issue 79553004: Security fix for untrusted signin confirm dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix unit tests Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm b/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

index 07029d1fea120d3bbbc04403e5c6d75de74d018d..be723e3d58b1346edb4dac582f0bdd0e8251a24b 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

+++ b/chrome/browser/ui/cocoa/one_click_signin_view_controller.mm

@@ -67,7 +67,7 @@ void ShiftOriginY(NSView* view, CGFloat amount) {

// the window and nothing else has initiated the sync, we must do so here

if (isSyncDialog_ && !startSyncCallback_.is_null()) {

base::ResetAndReturn(&startSyncCallback_).Run(

- OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS);

+ OneClickSigninSyncStarter::UNDO_SYNC);

}