chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm - Issue 79553004: Security fix for untrusted signin confirm dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm

Issue 79553004: Security fix for untrusted signin confirm dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix unit tests Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm b/chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm

index ec8ce3efdbd9c6f609c24e2c62279d212e1ac30b..15991c3c8ab7067bd16f15a2c1981e60b53cd1b0 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm

@@ -74,7 +74,7 @@ IN_PROC_BROWSER_TEST_F(OneClickSigninDialogControllerTest, Advanced) {

// Callback should be called to setup sync with default settings.

IN_PROC_BROWSER_TEST_F(OneClickSigninDialogControllerTest, Close) {

controller_->constrained_window()->CloseWebContentsModalDialog();

- EXPECT_EQ(OneClickSigninSyncStarter::SYNC_WITH_DEFAULT_SETTINGS, sync_mode_);

+ EXPECT_EQ(OneClickSigninSyncStarter::UNDO_SYNC, sync_mode_);

EXPECT_EQ(1, callback_count_);

}

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/one_click_signin_view_controller.mm » ('j') | no next file with comments »