Issue 795373005: Add GN interactive UI tests

Issue 795373005: Add GN interactive UI tests (Closed)

Created:
5 years, 11 months ago by brettw

Modified:
5 years, 11 months ago

Reviewers:
Dirk Pranke, dpranke

CC:
chromium-reviews, kalyank, sadrul

Base URL:
https://chromium.googlesource.com/chromium/src.git@tests

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add GN interactive UI tests TBR=dpranke Committed: https://crrev.com/0287a1a1750bbe22d3b4efb29b08b9aed13e723e Cr-Commit-Position: refs/heads/master@{#310040}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+295 lines, -38 lines)			Patch
M	ash/ash_resources.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/config/linux/BUILD.gn	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1	10 chunks	+36 lines, -32 lines	0 comments	Download
M	chrome/test/BUILD.gn	View	1 2	2 chunks	+246 lines, -6 lines	0 comments	Download
M	extensions/BUILD.gn	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	google_apis/google_apis.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	third_party/mesa/BUILD.gn	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 9 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795373005/40001

5 years, 11 months ago (2015-01-06 02:40:55 UTC) #4

commit-bot: I haz the power

Patchset 3 (id:??) landed as https://crrev.com/0287a1a1750bbe22d3b4efb29b08b9aed13e723e Cr-Commit-Position: refs/heads/master@{#310040}

5 years, 11 months ago (2015-01-06 02:54:35 UTC) #6

nhiroki

A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/823283005/ by nhiroki@chromium.org. ...

5 years, 11 months ago (2015-01-06 04:52:44 UTC) #7

Message was sent while issue was closed.

lgtm (apart from the chromeos failure, of course :).