Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 795363002: Fix live regions on Mac OS X. (Closed)

Created:
6 years ago by dmazzoni
Modified:
6 years ago
Reviewers:
aboxhall
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix live regions on Mac OS X. We were returning an empty string for AXARIALive for nodes inside of a live region, and that was confusing VoiceOver. BUG=440934 Committed: https://crrev.com/8f1a92f0876bdbf009d1745758f759551c03a253 Cr-Commit-Position: refs/heads/master@{#308029}

Patch Set 1 #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +4 lines, -2 lines 0 comments Download
A content/test/data/accessibility/aria-live-with-content.html View 1 1 chunk +21 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-live-with-content-expected-android.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-live-with-content-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-live-with-content-expected-win.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
6 years ago (2014-12-11 23:26:41 UTC) #2
aboxhall
lgtm
6 years ago (2014-12-12 00:04:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795363002/20001
6 years ago (2014-12-12 00:07:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-12 02:23:55 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-12 02:24:39 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8f1a92f0876bdbf009d1745758f759551c03a253
Cr-Commit-Position: refs/heads/master@{#308029}

Powered by Google App Engine
This is Rietveld 408576698