content/renderer/accessibility/blink_ax_tree_source.cc - Issue 795363002: Fix live regions on Mac OS X.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 795363002: Fix live regions on Mac OS X. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index c55d3266af568028f0623c65e1fee8cacf6e1324..b3abfac9d22cf611770526f94e3ab844522951ec 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -385,8 +385,10 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

dst->AddBoolAttribute(ui::AX_ATTR_LIVE_BUSY, src.liveRegionBusy());

if (src.liveRegionBusy())

dst->state |= (1 << ui::AX_STATE_BUSY);

- dst->AddStringAttribute(ui::AX_ATTR_LIVE_STATUS,

- UTF16ToUTF8(src.liveRegionStatus()));

+ if (!src.liveRegionStatus().isEmpty()) {

+ dst->AddStringAttribute(ui::AX_ATTR_LIVE_STATUS,

+ UTF16ToUTF8(src.liveRegionStatus()));

+ }

dst->AddStringAttribute(ui::AX_ATTR_LIVE_RELEVANT,

UTF16ToUTF8(src.liveRegionRelevant()));

dst->AddBoolAttribute(ui::AX_ATTR_CONTAINER_LIVE_ATOMIC,