Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 795233004: aria-pressed on a button should expose checked on android. (Closed)

Created:
6 years ago by shreeramk
Modified:
6 years ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aria-pressed on a button should expose checked on android. When aria-pressed is defined as {true/mixed} on button, then class android.widget.togglebutton is exposed, and its state on should be checked. BUG=171625 Committed: https://crrev.com/09151c6a1290892a3c81fe86d20f8826e7f9a9e3 Cr-Commit-Position: refs/heads/master@{#308722}

Patch Set 1 #

Patch Set 2 : updating expectations #

Patch Set 3 : updating aria-button epxectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M content/browser/accessibility/browser_accessibility_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/aria-button-expected-android.txt View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M content/test/data/accessibility/aria-pressed-expected-android.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
shreeramk
@aboxhall: please review. Thanks!!
6 years ago (2014-12-12 10:45:40 UTC) #2
shreeramk
On 2014/12/12 10:45:40, shreeramk wrote: > @aboxhall: please review. Thanks!! @aboxhall: updated failed expectations. PTAL. ...
6 years ago (2014-12-14 17:31:11 UTC) #3
dmazzoni
lgtm
6 years ago (2014-12-17 00:54:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/795233004/40001
6 years ago (2014-12-17 00:56:03 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-17 02:00:19 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-17 02:00:58 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/09151c6a1290892a3c81fe86d20f8826e7f9a9e3
Cr-Commit-Position: refs/heads/master@{#308722}

Powered by Google App Engine
This is Rietveld 408576698