content/browser/accessibility/browser_accessibility_android.cc - Issue 795233004: aria-pressed on a button should expose checked on android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_android.cc

Issue 795233004: aria-pressed on a button should expose checked on android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updating aria-button epxectations Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/accessibility/browser_accessibility_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_android.cc b/content/browser/accessibility/browser_accessibility_android.cc

index ce8f46d398edadc0a2d59c7499e118e2d2a17ab1..3b24585fdd250f84ede053e0c40522badfebb5b7 100644

--- a/content/browser/accessibility/browser_accessibility_android.cc

+++ b/content/browser/accessibility/browser_accessibility_android.cc

@@ -133,7 +133,7 @@ bool BrowserAccessibilityAndroid::IsCheckable() const {

}

bool BrowserAccessibilityAndroid::IsChecked() const {

- return HasState(ui::AX_STATE_CHECKED);

+ return (HasState(ui::AX_STATE_CHECKED) || HasState(ui::AX_STATE_PRESSED));

}

bool BrowserAccessibilityAndroid::IsClickable() const {

« no previous file with comments | « no previous file | content/test/data/accessibility/aria-button-expected-android.txt » ('j') | no next file with comments »