components/password_manager/core/browser/password_manager.cc - Issue 795183002: PasswordFormManager supports multiple drivers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 795183002: PasswordFormManager supports multiple drivers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added comment about non-blacklisted forms Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index d4694cc6e71f15bbb19d203ef398b10e45bf414a..8f280e75eb6067887917b5016fe84f7ca11ac8c5 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -435,7 +435,7 @@ void PasswordManager::CreatePendingLoginManagers(

}

old_manager_found = true;

if (old_manager->HasCompletedMatching())

- old_manager->MaybeTriggerAutofill();

+ old_manager->ProcessFrame(driver->AsWeakPtr());

break;

}

if (old_manager_found)